5 Commits

Author	SHA1	Message	Date
Valentin Shergin	bd91eaf664	Fabric/Text: ShadowNode::clone() - dynamic self-cloning mechanism ... Summary: The previous approach simply didn't work. :( As you might notice, in previous implementation of ViewShadowNode::cloneAndReplaceChild we used `ViewShadowNode` class for cloning `childNode`, and this is incorrect becasue `childNode` might be instance of any class. Reviewed By: fkgozali Differential Revision: D7595016 fbshipit-source-id: 2215414926f2f7a2e2fd05ca2d065f10d6d32b74	2018-04-26 18:03:06 -07:00
Valentin Shergin	6924d44b20	Fabric: Fixed ConcreteShadowNode::getProps() ... Summary: Apparently, there is no point to return a reference from this method because the struct (std::shared_ptr) is allocated on stack. The test is also updated. allow-large-files Reviewed By: fkgozali Differential Revision: D7557749 fbshipit-source-id: aa74146322c6d340256752586f05fc672024038e	2018-04-10 17:15:08 -07:00
Valentin Shergin	47c0ab91a5	Fabric: Using shallowSourceNode() inside ViewShadowNode::cloneAndReplaceChild() ... Summary: We have to call shallowSourceNode() in all cases of cloning which were not caused by UIManager instructions, otherwise the diffing alogorith might produce incorrect mutation instructions. Reviewed By: mdvacca Differential Revision: D7503383 fbshipit-source-id: b33e5c39b7ba8cbd0f925fd29b3af379441a40a4	2018-04-10 12:59:51 -07:00
Kevin Gozali	408a5f264b	iOS: added fabric/core ComponentDescriptor tests ... Summary: Basic test for ComponentDescriptor mechanism. Reviewed By: shergin Differential Revision: D7388297 fbshipit-source-id: 3b0c625656e31df03d71a2e036388621a5e2e21d	2018-03-23 17:32:52 -07:00
Kevin Gozali	e254474d4c	iOS: added fabric/core ShadowNode tests ... Summary: basic tests for shadow nodes and props for fabric Reviewed By: shergin Differential Revision: D7377867 fbshipit-source-id: dc8e5bb369aeb32b4790fd8b56f333376bc1578c	2018-03-23 17:32:52 -07:00