Commit Graph

56 Commits

Author SHA1 Message Date
Tom Clarkson 8a760e0a93 Code analysis bot does not need to comment on merge commits
Summary:
This PR fixes a CI issue that came up on #11304 after merging master into the pr branch.

That created a merge commit with over 1000 changed files. That might have created irrelevant comments, but the github commit api is limited to 300 files, with only the first 294 having the expected diffs included.

I can't think of any reasonable scenario where a merge would have changes that aren't either on master or another commit in the PR, so I've updated it to treat merge commits as having no changes.
Closes https://github.com/facebook/react-native/pull/13260

Differential Revision: D4819805

Pulled By: ericvicenti

fbshipit-source-id: 7b6b51b18bb36503a719a3ba5c9163cd6ef00e17
2017-04-03 11:15:44 -07:00
Andrew Rasmussen bf5aa9e1e7 Product Pains -> Canny
Summary:
We migrated everyone on Product Pains over to our new service, Canny. We also moved every product's feedback to a product-specific subdomain (eg. https://react-native.canny.io/feature-requests).

This PR updates every Product Pains URL over to its new Canny version.

Changes only affect docs, blog posts, and bot responses - not the React Native library itself.

**Test plan**

I visited https://react-native.canny.io/feature-requests. Since there are no code changes this seems sufficient but let me know if I need to run the blog website or something.
Closes https://github.com/facebook/react-native/pull/12429

Differential Revision: D4581492

Pulled By: hramos

fbshipit-source-id: 7d124ab7ed9228d47f1bc4417d8992f15ff17f01
2017-02-17 15:02:23 -08:00
Nicolas Cuillery 3b82f1db6f Add myself to the issue task force
Summary:
On the suggestion of mkonicek, I would like to handle the issues that are related to `react-native-git-upgrade`, by closing them with `close`, `answered` or `duplicate` instead of asking someone to do so.

Some issues where I missed this privilege: #11290, #11742 and recently #11951.
Closes https://github.com/facebook/react-native/pull/12035

Differential Revision: D4450851

Pulled By: hramos

fbshipit-source-id: 70a68c3a0f8cab3cbb637794c4797a8d0609e2af
2017-01-23 12:13:27 -08:00
Nicolas Charpentier c455c2bcc6 Add icebox command
Summary:
Add icebox command to comment, label and close an issue from one command instead of ping facebook bot serveral times. The goal is to reduce ping pollution, see the [current implementation](https://github.com/facebook/react-native/issues/6752#issuecomment-260830484).

Will be used by the Iceboxer script for people who only have access to the facebook-github-bot.

cc mkonicek
Closes https://github.com/facebook/react-native/pull/10963

Differential Revision: D4222330

Pulled By: mkonicek

fbshipit-source-id: 69ecf282a7004dfc23884e906bec582c58a749a8
2016-11-22 17:13:29 -08:00
Richard Evans 44b3cfe6bf Add rmevans9 to Github Issue Task Force
Summary:
Simply adding myself to the Github Issue Task Force so I can help out closing, tagging or whatever is needed for the issues.

Thanks!
Closes https://github.com/facebook/react-native/pull/9311

Differential Revision: D3690115

fbshipit-source-id: feb063df4f7d811e36d0d03dfad395e069d5b142
2016-08-09 05:58:28 -07:00
Melih Mucuk 523102b8e8 Add melihmucuk to Github Issue Task Force
Summary:
Here we go !
Closes https://github.com/facebook/react-native/pull/9143

Differential Revision: D3669363

Pulled By: mkonicek

fbshipit-source-id: 7fbd16be25736055bd2d84e34ad7e66f0d885a0a
2016-08-04 05:28:28 -07:00
Ryan Kaskel a37d5a825e Add ryankask to GitHub Issue task force
Summary:
I'm adding myself to the Issue Task Force based on a [comment](https://www.facebook.com/groups/react.native.community/permalink/805661392902774/?comment_id=805736189561961) from mkonicek in the RN Community FB group.
Closes https://github.com/facebook/react-native/pull/9100

Differential Revision: D3646946

fbshipit-source-id: e9a3742ef3dc79af2f2892e1ce0500073f73bf4e
2016-07-30 02:13:26 -07:00
Zakaria Ridouh 97cfacb5ba move templates to .github folder
Summary:
This moves the Template files to the .github folder. This helps clear up the extra files in the root of the directory.

This is my first PR 😄  and I plan to contribute more to this awesome project.
Closes https://github.com/facebook/react-native/pull/7854

Differential Revision: D3424679

fbshipit-source-id: 2baca0bb4182eb6d803836e10a5434d980e7d0c3
2016-06-13 07:43:28 -07:00
Damien Varron 048775c34b add damusnet to React Native GitHub Issue Task Force
Summary: Closes https://github.com/facebook/react-native/pull/7354

Differential Revision: D3257999

fb-gh-sync-id: 102d761d3aac50a8bcef82bcd1ce5919a5681dbf
fbshipit-source-id: 102d761d3aac50a8bcef82bcd1ce5919a5681dbf
2016-05-04 01:08:21 -07:00
Mike Grabowski 9bae30f8b5 Add `cla` command
Summary:Hey,

Adding a `cla` command to bot so that we can ping users that forgot about it more conveniently. I am not really sure if that's everything we have to do in order for the bot to use it - but just wanted to give it a go.

Differential Revision: D3212234

fb-gh-sync-id: 5f75f88694b21b883e7da2af41d4e389fb828839
fbshipit-source-id: 5f75f88694b21b883e7da2af41d4e389fb828839
2016-04-22 04:24:24 -07:00
Christopher Dro 63adb48dc4 Add Zack Story 'rt2zz'
Summary:/cc rt2zz
Closes https://github.com/facebook/react-native/pull/7000

Differential Revision: D3184798

fb-gh-sync-id: b1f4eab40db7c753f7e3773502852bf9a0d05861
fbshipit-source-id: b1f4eab40db7c753f7e3773502852bf9a0d05861
2016-04-21 22:44:24 -07:00
Andrew Jack 200b6fa277 Add myself to the issues task force
Summary: Closes https://github.com/facebook/react-native/pull/6980

Differential Revision: D3181069

fb-gh-sync-id: ed39452c071c83e5fede352d61b3a293180f5b52
fbshipit-source-id: ed39452c071c83e5fede352d61b3a293180f5b52
2016-04-14 14:42:26 -07:00
Konstantin Raev c3c7249689 @facebook-github-bot feature is now a bit nicer to people
Summary:mkonicek how can I add a line break to that?
Closes https://github.com/facebook/react-native/pull/6742

Differential Revision: D3120662

fb-gh-sync-id: 292ff3ae35c7ba4f583d3d3d4d5993812823e112
fbshipit-source-id: 292ff3ae35c7ba4f583d3d3d4d5993812823e112
2016-03-31 07:07:24 -07:00
Martin Konicek 032b37080c Fix typo
Reviewed By: mkonicek

Differential Revision:D3074988
Ninja: oss only

fb-gh-sync-id: 9e97b662d36bd8aed8f34b7afeaa1d532f0da74d
shipit-source-id: 9e97b662d36bd8aed8f34b7afeaa1d532f0da74d
2016-03-20 13:26:27 -07:00
Martin Konicek 8a86616bc0 Tweak commands and guidelines
Reviewed By: mkonicek

Differential Revision:D3074972
Ninja: oss only

fb-gh-sync-id: 0f244c80851d14fddd0a37e5357b5a00224aa97d
shipit-source-id: 0f244c80851d14fddd0a37e5357b5a00224aa97d
2016-03-20 13:14:25 -07:00
Konstantin Raev 029aa5bf2c fixed facebook-github-bot command duplication
Summary:clowns
Closes https://github.com/facebook/react-native/pull/6550

Differential Revision: D3074924

Pulled By: mkonicek

fb-gh-sync-id: c014726bfc42c8d8820ec4cca13ec252ebdc50fc
shipit-source-id: c014726bfc42c8d8820ec4cca13ec252ebdc50fc
2016-03-20 12:48:24 -07:00
Satyajit Sahoo dad6e290f8 Improve bookmarklets to include author name
Summary:Including author's name makes the replies more personalized.
Closes https://github.com/facebook/react-native/pull/6545

Differential Revision: D3074715

Pulled By: mkonicek

fb-gh-sync-id: ac21ddc2c2864585c3a16ad0be7619ba432831b3
shipit-source-id: ac21ddc2c2864585c3a16ad0be7619ba432831b3
2016-03-20 11:54:27 -07:00
Konstantin Raev 432edd6b39 facebook-github-bot feature wording improvement
Summary:As mkonicek suggested in #6544
Closes https://github.com/facebook/react-native/pull/6549

Differential Revision: D3074890

Pulled By: mkonicek

fb-gh-sync-id: 26be47b948ed33f1569f7d6f5369da20700d0dd6
shipit-source-id: 26be47b948ed33f1569f7d6f5369da20700d0dd6
2016-03-20 11:39:23 -07:00
Konstantin Raev 150811534d added new bot command feature
Summary: Closes https://github.com/facebook/react-native/pull/6544

Differential Revision: D3074863

Pulled By: mkonicek

fb-gh-sync-id: e1e90ed1e4c2d8da84e3684915c375231bd8fb66
shipit-source-id: e1e90ed1e4c2d8da84e3684915c375231bd8fb66
2016-03-20 11:04:24 -07:00
Martin Konicek 25cc7b7174 Add charpeni, DanielMSchmidt and knowbody to issue task force
Reviewed By: mkonicek

Differential Revision:D3074096
Ninja: oss only

fb-gh-sync-id: 41ca51d7b09686ec70120af961217a40bd9d433e
shipit-source-id: 41ca51d7b09686ec70120af961217a40bd9d433e
2016-03-19 11:48:28 -07:00
Chris Geirman 05b9902ae6 add myself to the issues task force
Summary: Closes https://github.com/facebook/react-native/pull/6533

Differential Revision: D3073929

Pulled By: mkonicek

fb-gh-sync-id: 5aa2c4b8d0077729693874c9b9a3832377d44b2c
shipit-source-id: 5aa2c4b8d0077729693874c9b9a3832377d44b2c
2016-03-19 07:29:28 -07:00
Konstantin Raev da5596c97d fixed flow error on Travis
Summary: Closes https://github.com/facebook/react-native/pull/6530

Differential Revision: D3071277

fb-gh-sync-id: e2cfd2d2a8cbf5a862dcdb79fe834b1fdbcba107
shipit-source-id: e2cfd2d2a8cbf5a862dcdb79fe834b1fdbcba107
2016-03-19 02:15:24 -07:00
Konstantin Raev 84183ffc30 Improved OSS flow and lint reporting
Summary:- lint bot is now managed by Circle CI
- checked that flow and lint errors are caught both by bot and CI
- flow fix for npm 3
- Travis is now using npm 2 and Circle CI npm 3
- Refactored Travis script to be able to be able to fail on multiple lines
Closes https://github.com/facebook/react-native/pull/6508

Differential Revision: D3069500

Pulled By: davidaurelio

fb-gh-sync-id: 02772bf1eae5f2c44489c2e3a01899428a9640cb
shipit-source-id: 02772bf1eae5f2c44489c2e3a01899428a9640cb
2016-03-18 08:10:26 -07:00
Martin Konicek 3418dd5621 Update issue bot commands and guidelines
Reviewed By: mkonicek

Differential Revision:D3029843
Ninja: oss only

fb-gh-sync-id: b8de21e9947904c572b2214f284c35be0c1af616
shipit-source-id: b8de21e9947904c572b2214f284c35be0c1af616
2016-03-09 08:18:26 -08:00
Janic Duplessis e9c96451e0 Add issue bot close command and add janicduplessis to the bot whitelist
Summary:Adds a generic close command to the issue bot and add myself to the task force list.
Closes https://github.com/facebook/react-native/pull/6349

Reviewed By: mkonicek

Differential Revision:D3021271
Ninja: RN GitHub bot only

Pulled By: mkonicek

fb-gh-sync-id: dbdce129c4287173a4c16889c16bb5ed9ded5f79
shipit-source-id: dbdce129c4287173a4c16889c16bb5ed9ded5f79
2016-03-07 15:35:07 -08:00
Martin Konicek f0f1f61b40 Update PR and issue templates and guidelines
Summary:- Simplified the PR and Issue template to make them easier to read.
- Add a very simple guide for reviewing PRs (cc bestander, feel free to add to this)
Closes https://github.com/facebook/react-native/pull/6295

Differential Revision: D3011905

fb-gh-sync-id: 4929921690a6996e574e6b152a9dd41087cfffdc
shipit-source-id: 4929921690a6996e574e6b152a9dd41087cfffdc
2016-03-04 09:20:37 -08:00
Martin Konicek d03338073f Tweak wording of issue guidelines
Reviewed By: mkonicek

Differential Revision:D2990021
Ninja: oss docs

fb-gh-sync-id: ba79d6b78c55439fc1dbbf081d93edad84690f73
shipit-source-id: ba79d6b78c55439fc1dbbf081d93edad84690f73
2016-02-29 11:37:36 -08:00
Martin Konicek 10e8e38677 Update GitHub issue guidelines
Reviewed By: mkonicek

Differential Revision:D2989742
Ninja: oss docs

fb-gh-sync-id: c9fc233b248d5ddda4c046d04cdfcafc3c97af90
shipit-source-id: c9fc233b248d5ddda4c046d04cdfcafc3c97af90
2016-02-29 11:13:32 -08:00
Martin Konicek 732f2e17ac List people who manage GitHub issues
Reviewed By: mkonicek

Differential Revision:D2980915
Ninja: oss only

fb-gh-sync-id: 36aa06a4b5c189f452939ce563d2857f793de015
shipit-source-id: 36aa06a4b5c189f452939ce563d2857f793de015
2016-02-25 18:30:38 -08:00
Martin Konicek 3faa70ab4f Add guidelines for managing GitHub issues
Reviewed By: mkonicek

Differential Revision:D2971827
Ninja: oss only

fb-gh-sync-id: b86b74a8a582f159777fb90da23645ee730a4802
shipit-source-id: b86b74a8a582f159777fb90da23645ee730a4802
2016-02-24 09:38:30 -08:00
Martin Konicek 7a87d38044 Fix typos in bot messages
Reviewed By: mkonicek

Differential Revision:D2951913
Ninja: oss

fb-gh-sync-id: 0d2d43a39735e23ae456e10ee33276d70464e0ca
shipit-source-id: 0d2d43a39735e23ae456e10ee33276d70464e0ca
2016-02-18 16:00:42 -08:00
Martin Konicek 0fdb1671e3 Tweak bot messages and issue template to make them a bit more friendly
Reviewed By: mkonicek

Differential Revision:D2951452
Ninja: oss

fb-gh-sync-id: a42ee8061e37d7b389fcce0a26a16411b43c1d05
shipit-source-id: a42ee8061e37d7b389fcce0a26a16411b43c1d05
2016-02-18 15:11:55 -08:00
Martin Konicek 80e458110b Issue bot: add reopen command
Reviewed By: mkonicek

Differential Revision:D2950378
Ninja: oss

fb-gh-sync-id: bf9e6d5a3889ca1c1e95bf4b8aed63afd3030da6
shipit-source-id: bf9e6d5a3889ca1c1e95bf4b8aed63afd3030da6
2016-02-18 11:54:59 -08:00
Martin Konicek f2b95f2b87 Add commands for a new issue bot
Reviewed By: mkonicek

Differential Revision:D2944312
Ninja: yet to be used

fb-gh-sync-id: 17b22063539612ce48eb4acac62f452ca4d65c1d
shipit-source-id: 17b22063539612ce48eb4acac62f452ca4d65c1d
2016-02-17 09:05:33 -08:00
Martin Konicek 9bbcb5baf7 Update bots/README.md 2016-01-12 15:11:24 +00:00
Martin Konicek f7de9678d4 Update NewIssueGreeting.md 2015-12-24 01:10:21 +01:00
Martin Konicek 09702478f1 Update NewIssueGreeting.md 2015-12-24 01:08:13 +01:00
Satyajit Sahoo d5f238638a Ask to specify the platform in new issue greeting 2015-12-23 05:34:56 +05:30
Martin Konicek 476b0af510 Update NewIssueGreeting.md 2015-12-13 14:14:09 +00:00
Christopher Chedeau 402fd06725 Introduce code-analysis bot 2015-12-11 08:44:12 -08:00
James Ide 9d333e6411 Update NewIssueGreeting.md 2015-11-24 10:29:40 -08:00
Martin Konicek 55f72c4c8f Update question-bookmarklet.js 2015-11-24 16:55:29 +00:00
Martin Konicek 918ef31e10 Update NewIssueGreeting.md 2015-11-24 15:47:29 +00:00
James Ide e49c70026a [Issues] Solicit high quality issues and PRs 2015-11-23 16:18:16 -08:00
Martin Konicek 5d9b8d9c15 Update NewIssueGreeting.md 2015-11-24 00:07:40 +00:00
Christopher Chedeau 8ccd13b9b6 Update NewIssueGreeting.md 2015-11-23 16:05:51 -08:00
Martin Konicek 6b8f3da955 Update NewIssueGreeting.md 2015-11-23 23:57:54 +00:00
Martin Konicek 848a151ff8 Add a bookmarklet to comment on questions
For higher accuraccy (and less clowniness) it might be better
to have the question bot only label issues that are potentially
questions and then have people quickly go through those issues
and use this bookmarklet to comment on them.
2015-11-20 14:26:59 +00:00
James Ide dbba143a7a [Bot] Adjust the some of the wording of the NewIssueGreeting
Made it a little more terse and replaced "We have limited bandwidth" for more clarity.
2015-11-18 15:07:15 -08:00
Martin Konicek 5f170be213 Update QuestionGreeting.md 2015-11-18 20:32:27 +00:00