6138e20379
give us the ability to create a background UI thread
...
Reviewed By: javache
Differential Revision: D4928689
fbshipit-source-id: 94fa5f3f7c047ad816c7699dcc8bebf9e751b282
2017-04-21 05:30:22 -07:00
b4932082c7
List nested exception in Redbox
...
Reviewed By: AaaChiuuu
Differential Revision: D4928968
fbshipit-source-id: 3af8f4ad0f76f035d2167fbf4b4381b6503f6bd2
2017-04-21 05:30:22 -07:00
3a3e5affc3
add flag to test running BG UI operation on a separate thread from the native modules thread
...
Reviewed By: achen1
Differential Revision: D4912045
fbshipit-source-id: b0b1aea24f8d463b95369636b7df2422a23aab22
2017-04-20 16:15:38 -07:00
97a86634f7
lower thread priority of native module and JS thread
...
Reviewed By: achen1
Differential Revision: D4921012
fbshipit-source-id: 71df4ab0614f20f092b992c07e828eb5ad951159
2017-04-20 15:35:58 -07:00
38f5b84734
Make ModuleHolder usable from C++
...
Reviewed By: AaaChiuuu
Differential Revision: D4924286
fbshipit-source-id: f4d86603cf241ab21f931fed4798acd805d0b5aa
2017-04-20 15:01:20 -07:00
17020ff9af
Add API to reset CxxModuleWrapper's module pointer
...
Reviewed By: mhorowitz
Differential Revision: D4914335
fbshipit-source-id: f28f57c2e74d590dacfb85d8027747837f768fdc
2017-04-20 11:00:33 -07:00
366cb5a00a
Remove unused PersistentDirectory JSC config
...
Reviewed By: amnn
Differential Revision: D4921075
fbshipit-source-id: 8e0a0caadc882a0e3ffb6f66c2bc7336c7d64849
2017-04-20 03:15:26 -07:00
350b6c6d7f
don't run setupReactContext() on UI thread
...
Reviewed By: achen1
Differential Revision: D4816125
fbshipit-source-id: e1da5de166bc29d635ffa22e8747a5b61eaf1491
2017-04-20 01:30:59 -07:00
3e866e0380
launch conversion from ASyncTask to Thread
...
Reviewed By: achen1
Differential Revision: D4900998
fbshipit-source-id: af2283525b4e9856d7ff3466096226c4c1209f6b
2017-04-18 20:32:02 -07:00
3fda6a9a2b
clear DraweeControllerBuilder after usage
...
Reviewed By: achen1
Differential Revision: D4908279
fbshipit-source-id: 8de9930a2160f3201f8b7a8a66415310fa2f41de
2017-04-18 20:07:05 -07:00
54d8d10a6b
Construct ModuleHolder from ReactModuleInfo
...
Reviewed By: AaaChiuuu
Differential Revision: D4883331
fbshipit-source-id: c901051d0aa5993142104126bbec5d76bd605e0b
2017-04-18 06:48:04 -07:00
035f076594
move calls that need to be on the UI thread out of setupReactContext()
...
Reviewed By: achen1
Differential Revision: D4890541
fbshipit-source-id: 7fc87d3341a1cefd474481dcc1b7b6d02d92f445
2017-04-18 04:15:34 -07:00
b9eeaef243
make ReactInstanceManager safer threading wise
...
Reviewed By: achen1
Differential Revision: D4883219
fbshipit-source-id: 45671a6d51357fd51ca824a59f7b200c3df66b89
2017-04-18 04:15:34 -07:00
ff056d22d9
update the infer-annotation jar for open source to unblock D4883219
...
Reviewed By: achen1
Differential Revision: D4890251
fbshipit-source-id: 3945c0e85fba15d588aa3b5760c64c5d81c6c516
2017-04-17 15:57:36 -07:00
1dc0f7e994
Instrumentation tests for apps that provide a testPayload
...
Reviewed By: AaaChiuuu
Differential Revision: D4873849
fbshipit-source-id: b5235b952faea2e42fb4292fac4ca409e22ecb56
2017-04-17 15:00:44 -07:00
9c44630866
make mReactChoreographer final in Timing.java
...
Reviewed By: achen1
Differential Revision: D4883119
fbshipit-source-id: 1adb57f333742fca9c5e1ece6355ee18881c48a4
2017-04-17 13:30:03 -07:00
1c440dbcae
clean up NativeAnimatedModule
...
Reviewed By: achen1
Differential Revision: D4883111
fbshipit-source-id: 63873d46db8d2736672a6d102e86dabfbf4f4610
2017-04-14 16:31:23 -07:00
b9b03435c4
loosen the ReactChoreographer UI thread assert
...
Reviewed By: achen1
Differential Revision: D4873553
fbshipit-source-id: 7dbf771e744f6b33e6edb3ad4c227c3a63c3e3e3
2017-04-14 02:45:33 -07:00
c9826ba4a9
make mHasDispatchScheduledCount in EventDispatcher atomic
...
Reviewed By: achen1
Differential Revision: D4882881
fbshipit-source-id: ac9a985287bd4720846ecde97ebb4935963c0d9f
2017-04-14 02:15:46 -07:00
2030c78355
Remove references to CSSLayoutDEPRECATED
...
Reviewed By: marco-cova
Differential Revision: D4859822
fbshipit-source-id: 2588c1b3334f28332ae43e6c0bdec65934ca84c4
2017-04-13 12:52:38 -07:00
8e382fd006
Find hasConstant status via preprocessing
...
Reviewed By: javache
Differential Revision: D4867563
fbshipit-source-id: 66e4505d142fc4776cd727a025005b43d500b167
2017-04-13 05:30:14 -07:00
625b4940ee
FLog.w ==> Flog.d
...
Reviewed By: yungsters
Differential Revision: D4874628
fbshipit-source-id: ae39a7105145f11b749822f3c98db973cfe613eb
2017-04-12 00:42:57 -07:00
8290cd7ce2
Fix ARTShape arc
...
Reviewed By: AaaChiuuu
Differential Revision: D4871406
fbshipit-source-id: 7f777048c6756399b309e34cf3341c4263467b0b
2017-04-11 19:35:09 -07:00
6b900dc7fb
Fix withCredentials test failure
...
Reviewed By: AaaChiuuu
Differential Revision: D4870817
fbshipit-source-id: d741eb21d4c7092f89d5a8461b9ec92e3df49120
2017-04-11 18:30:35 -07:00
21819f1a99
Add support for async callbacks in ReactFindViewUtil
...
Reviewed By: AaaChiuuu
Differential Revision: D4841500
fbshipit-source-id: 16620d72bd636ad13085c15c38862e16da6c42d2
2017-04-11 10:45:35 -07:00
3184f314ad
Fix NPE in StackTraceHelper
...
Reviewed By: AaaChiuuu
Differential Revision: D4860056
fbshipit-source-id: 68865d8d8d1c2a678970f10e99d2ae5bc31ea5f8
2017-04-11 04:29:55 -07:00
e544563bd2
BREAKING: Android: Support withCredentials flag in XHRs
...
Summary:
Corresponding iOS PR: #12275
Respect the withCredentials XMLHttpRequest flag for sending cookies with requests. This can reduce payload sizes where large cookies are set for domains.
This should fix #5347 .
This is a breaking change because it alters the default behavior of XHR. Prior to this change, XHR would send cookies by default. After this change, by default, XHR does not send cookies which is consistent with the default behavior of XHR on web for cross-site requests. Developers can restore the previous behavior by passing `true` for XHR's `withCredentials` argument.
**Test plan (required)**
Verified in a test app that XHR works properly when specifying `withCredentials` as `true`, `false`, and `undefined`. Also, my team uses this change in our app.
Adam Comella
Microsoft Corp.
Closes https://github.com/facebook/react-native/pull/12276
Differential Revision: D4673646
Pulled By: ericvicenti
fbshipit-source-id: 924c230c9df72071b3cf9151c3ac201905ac28a5
2017-04-10 22:46:12 -07:00
78ab4ee893
Delay module creation on call for constants when module has none
...
Reviewed By: AaaChiuuu
Differential Revision: D4810252
fbshipit-source-id: b2b98c3a8355dbb5775f254f25304a21f0bfee5b
2017-04-10 03:16:36 -07:00
678679e009
Separate findMethods from BaseJavaModule
...
Reviewed By: javache
Differential Revision: D4795087
fbshipit-source-id: 6d135a409d463940a5a0aabbc85682ed61420ae3
2017-04-10 03:16:36 -07:00
8591d8ae71
Webview disable save form prop
...
Summary:
Adds functionality to be able to disable saving of form data and thereby disabling autocomplete in webview on Android. Can be used as a workaround for #13241
Manual testing that autocomplete is disabled when the property is set to true, and still enabled when it is unset or set to false.
Closes https://github.com/facebook/react-native/pull/13271
Differential Revision: D4858899
Pulled By: ericvicenti
fbshipit-source-id: 62738b0685e4c1958c8a32e184fa2fe4f711b336
2017-04-09 21:45:45 -07:00
909af08f24
Add a nativeID prop to allow native code to reference react managed views
...
Reviewed By: sahrens
Differential Revision: D4786713
fbshipit-source-id: af9cef0737c010b429d52d00181c00bd81f13f5b
2017-04-07 12:00:40 -07:00
e154117f37
Add proguard rules to bridge BUCK
...
Summary:
prevents reflected classes from being stripped/obfuscated
Depends on D4830910
Reviewed By: mhorowitz
Differential Revision: D4835688
fbshipit-source-id: 5b85668f92ed4ae5cebc9902ec60f6d5d6299bd4
2017-04-07 11:46:12 -07:00
b5327dd388
Set the enabled state on disabled button views
...
Reviewed By: AaaChiuuu
Differential Revision: D4722513
fbshipit-source-id: f4a4e6304594235b5da4e5be36358331e43bdbee
2017-04-06 21:32:05 -07:00
5f37483466
Revert D4840716: Refactor interfaces
...
Differential Revision: D4840716
fbshipit-source-id: 1b6a6050d78ccbbd3c817621df1c1c989594fdb1
2017-04-06 06:03:10 -07:00
fd99330b6c
Refactor interfaces
...
Reviewed By: johnislarry
Differential Revision: D4840716
fbshipit-source-id: 1a82437c81ce5b767efd39ab0716998bab4f5363
2017-04-06 00:04:06 -07:00
3bf367cbb7
Use tag ids for testID
...
Summary: View tags are currently used for end-to-end test IDs. We'd like to overload the tag field with other information such as nativeID (for native refs) and transitionID (for shared element transitions) in the future. Added a key for testID's tag
Reviewed By: AaaChiuuu
Differential Revision: D4833045
fbshipit-source-id: c2f9371c9a3dbb2411e114f4f096f723ac3132c0
2017-04-05 12:39:29 -07:00
9a51fa8e15
Improve z-index implementation on Android
...
Summary:
Use `getChildDrawingOrder` instead of reordering views. The old implementation didn't work properly when `removeClippedSubviews` was enabled and this one should have better performance since we don't play with the view hierarchy at all.
This fixes weird bugs with sticky headers in `SectionList` and allows removing the hack that disabled `removeClippedSubviews` when using sticky section headers.
**Test plan**
Tested using the SectionList and ListViewPaging examples that use sticky headers which uses z-index.
Closes https://github.com/facebook/react-native/pull/13105
Reviewed By: sahrens
Differential Revision: D4765869
Pulled By: achen1
fbshipit-source-id: be3c824658a3ce965b6e7324ad95c77cbd8a86ae
2017-04-05 09:17:46 -07:00
af533ac7f1
Remove the dependency of I18nManagerModule on ReactApplicationContext
...
Reviewed By: javache
Differential Revision: D4809492
fbshipit-source-id: 775c6b95aab734568ea4750804477c04d13502b6
2017-04-05 01:07:48 -07:00
a893d0bb23
Refactor CxxModuleWrapper to support different use cases
...
Reviewed By: javache
Differential Revision: D4807680
fbshipit-source-id: 48eccfb382814a0c4082f56617e0359e61345da7
2017-04-05 01:07:48 -07:00
0ec9c93eeb
Add comment about adding new resource directories
...
Reviewed By: ericvicenti
Differential Revision: D4833151
fbshipit-source-id: 64ad77e7c4d277f19d1c545dc1d75ab870ddd49e
2017-04-04 23:00:26 -07:00
2b0282aa69
#11587 invoke error for getCurrentLocation
...
Summary:
It started with https://github.com/facebook/react-native/issues/11587 , which reported that the error returned by `getCurrentLocation` did not match the spec.
This resulted in PR https://github.com/facebook/react-native/pull/11723 , which did not get merged because it was said by ide and mkonicek that simply emitting the error will cause it to hang since the `error` callback was never invoked.
However, it seems like somewhere along the way PR https://github.com/facebook/react-native/pull/13140 got merged in which did exactly that.
Since it now matches the spec, turning off location services on Android then running the below example code from [Geolocation](https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/getCurrentPosition ) docs errors out correctly.
```javascript
var options = {
enableHighAccuracy: true,
timeout: 5000,
maximumAge: 0
};
function success(pos) {
var crd = pos.coords;
console.log('Your current po
Closes https://github.com/facebook/react-native/pull/13306
Differential Revision: D4833377
Pulled By: ericvicenti
fbshipit-source-id: dbea5948790a3f521751a0cc0a25f0e323b30667
2017-04-04 22:18:58 -07:00
eb300b60f3
Revert D4770368: [rn] Use tag ids for testID
...
Differential Revision: D4770368
fbshipit-source-id: 4bf8131a2a2974c8db072f62e8fb26686faa100d
2017-04-04 15:09:51 -07:00
c0b64ce519
use Log.d instead of Log.w in CatalystInstanceImpl.java
...
Reviewed By: achen1
Differential Revision: D4829620
fbshipit-source-id: d3648b7b9afdaec30790995e59abe23805fb6b1e
2017-04-04 14:56:29 -07:00
f8e583b2d0
clean out the last used bitmap
...
Reviewed By: achen1
Differential Revision: D4828134
fbshipit-source-id: bf54f7c9f61016cc0735338f99de7b0378c1234b
2017-04-04 12:46:43 -07:00
77c19ccf73
Use tag ids for testID
...
Summary: View tags are currently used for end-to-end test IDs. We'd like to overload the tag field with other information such as nativeID (for native refs) and transitionID (for shared element transitions) in the future. Added a key for testID's tag
Reviewed By: AaaChiuuu
Differential Revision: D4770368
fbshipit-source-id: b76c53a20520aac1b25d435b6d5eb809e8833675
2017-04-04 12:33:30 -07:00
f1371ec24c
Don't transfer layout outputs to java for unset edges
...
Summary:
See facebook/yoga#483 . We should not transfer the layout if the layout didn't change. (using ```hasNewLayout```). This also changes that the lock on the java node is only aquired if needed, and it holds the lock only for the time the values are set and not for the time all it's children are set.
Closes https://github.com/facebook/yoga/pull/484
Reviewed By: astreet
Differential Revision: D4802966
Pulled By: emilsjolander
fbshipit-source-id: e8a8f2280ad6b25b98fc68b07eac68e0ec80fe3e
2017-04-01 04:34:17 -07:00
175e77d004
break dependency between JSPackagerClient.RequestHandler and WebSocketListener
...
Reviewed By: amnn
Differential Revision: D4810406
fbshipit-source-id: a447bc15c6619921edd7adf0b3d1d93ae04e2e43
2017-03-31 11:02:07 -07:00
01a0e10026
Make SystraceRequestListener extend BaseRequestListener
...
Summary: Instead of `SystraceRequestListener` implementing `RequestListener`, this diff instead extends the base implementation.
Reviewed By: massimocarli
Differential Revision: D4796679
fbshipit-source-id: 0c9a0b755f4beff69007688962682989e5af72e0
2017-03-31 03:03:06 -07:00
ec4b85467d
Allow DeviceInfoModule to be instantiated with only an android Context
...
Reviewed By: javache
Differential Revision: D4772673
fbshipit-source-id: 80894faa076ccfddf0fe28bd4d7b6aaeba6c38a5
2017-03-31 01:00:52 -07:00
1916b38a65
Support passing a collection of native modules to JSContext
...
Reviewed By: javache
Differential Revision: D4772649
fbshipit-source-id: dd9353edb0c2c013a3b7fe772231db12cdd8cdae
2017-03-31 01:00:52 -07:00
Aaron Chiu
Pieter De Baets
Marc Horowitz
Andrew Y. Chen
Emil Sjolander
Kathy Gray
Adam Comella
Faraz Sherwani
Benjamin Jaeger
Martin Kralik
Theo Yaung
Janic Duplessis
daose
Lukas Wöhrl
Charles Dick
Kirwan Lyster