status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

clear DraweeControllerBuilder after usage 

Reviewed By: achen1

Differential Revision: D4908279

fbshipit-source-id: 8de9930a2160f3201f8b7a8a66415310fa2f41de
This commit is contained in:
Aaron Chiu 2017-04-18 19:59:57 -07:00 committed by Facebook Github Bot
parent 8f2d73d50b
commit 3fda6a9a2b
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java
View File

@ -449,6 +449,10 @@ public class ReactImageView extends GenericDraweeView {
setController(mDraweeControllerBuilder.build());
mIsDirty = false;
// Reset again so the DraweeControllerBuilder clears all it's references. Otherwise, this causes
// a memory leak.
mDraweeControllerBuilder.reset();
}
// VisibleForTesting

1
ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageSpan.java
View File

@ -141,6 +141,7 @@ public class FrescoBasedReactTextInlineImageSpan extends TextInlineImageSpan {
.setImageRequest(imageRequest)
.build();
mDraweeHolder.setController(draweeController);
mDraweeControllerBuilder.reset();
mDrawable = mDraweeHolder.getTopLevelDrawable();
mDrawable.setBounds(0, 0, mWidth, mHeight);