status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Updated Mac/Linux ANDROID_HOME path to include ${HOME} 

Summary:
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

Using `~` in the `.bashrc` or `.zshrc` fails inside of double quotes.  By changing this to `$HOME` the path is exported correctly in all instances.

Explain the **motivation** for making this change. What existing problem does the pull request solve?

It corrects the path to the Android home location if SDK is installed via Android Studio. Using `~` for the home path is failing.  By added `$HOME` you are guaranteed the correct path.

Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

**Test plan (required)**

Install Android Studio & SDK.
Set environment variable in `.bashrc` or `.zshrc` with `${HOME}/Library/Android/sdk` instead of `~/Library/Android/sdk`

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the p
Closes https://github.com/facebook/react-native/pull/11461

Differential Revision: D4327870

Pulled By: JoelMarcey

fbshipit-source-id: 903a84504f6288c73ac39a8f3b8800ededbdccf9
This commit is contained in:
Dayne Wright 2016-12-14 15:25:00 -08:00 committed by Facebook Github Bot
parent 8832479e28
commit eb43f155b4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/GettingStarted.md
View File

@ -224,7 +224,7 @@ The React Native command line interface requires the `ANDROID_HOME` environment
Add the following lines to your `~/.bashrc` (or equivalent) config file: Add the following lines to your `~/.bashrc` (or equivalent) config file:
``` ```
export ANDROID_HOME=~/Library/Android/sdk export ANDROID_HOME=${HOME}/Library/Android/sdk
export PATH=${PATH}:${ANDROID_HOME}/tools export PATH=${PATH}:${ANDROID_HOME}/tools
export PATH=${PATH}:${ANDROID_HOME}/platform-tools export PATH=${PATH}:${ANDROID_HOME}/platform-tools
``` ```
@ -236,7 +236,7 @@ export PATH=${PATH}:${ANDROID_HOME}/platform-tools
Add the following lines to your `~/.bashrc` (or equivalent) config file: Add the following lines to your `~/.bashrc` (or equivalent) config file:
``` ```
export ANDROID_HOME=~/Android/Sdk export ANDROID_HOME=${HOME}/Android/Sdk
export PATH=${PATH}:${ANDROID_HOME}/tools export PATH=${PATH}:${ANDROID_HOME}/tools
export PATH=${PATH}:${ANDROID_HOME}/platform-tools export PATH=${PATH}:${ANDROID_HOME}/platform-tools
``` ```