From eb43f155b4101bf71f07ab2aec88ad91c637f325 Mon Sep 17 00:00:00 2001 From: Dayne Wright Date: Wed, 14 Dec 2016 15:25:00 -0800 Subject: [PATCH] Updated Mac/Linux ANDROID_HOME path to include ${HOME} Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: Using `~` in the `.bashrc` or `.zshrc` fails inside of double quotes. By changing this to `$HOME` the path is exported correctly in all instances. Explain the **motivation** for making this change. What existing problem does the pull request solve? It corrects the path to the Android home location if SDK is installed via Android Studio. Using `~` for the home path is failing. By added `$HOME` you are guaranteed the correct path. Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Install Android Studio & SDK. Set environment variable in `.bashrc` or `.zshrc` with `${HOME}/Library/Android/sdk` instead of `~/Library/Android/sdk` Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the p Closes https://github.com/facebook/react-native/pull/11461 Differential Revision: D4327870 Pulled By: JoelMarcey fbshipit-source-id: 903a84504f6288c73ac39a8f3b8800ededbdccf9 --- docs/GettingStarted.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/GettingStarted.md b/docs/GettingStarted.md index 0dd7b9786..f6e3da237 100644 --- a/docs/GettingStarted.md +++ b/docs/GettingStarted.md @@ -224,7 +224,7 @@ The React Native command line interface requires the `ANDROID_HOME` environment Add the following lines to your `~/.bashrc` (or equivalent) config file: ``` -export ANDROID_HOME=~/Library/Android/sdk +export ANDROID_HOME=${HOME}/Library/Android/sdk export PATH=${PATH}:${ANDROID_HOME}/tools export PATH=${PATH}:${ANDROID_HOME}/platform-tools ``` @@ -236,7 +236,7 @@ export PATH=${PATH}:${ANDROID_HOME}/platform-tools Add the following lines to your `~/.bashrc` (or equivalent) config file: ``` -export ANDROID_HOME=~/Android/Sdk +export ANDROID_HOME=${HOME}/Android/Sdk export PATH=${PATH}:${ANDROID_HOME}/tools export PATH=${PATH}:${ANDROID_HOME}/platform-tools ```