status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-10 08:26:23 +00:00
Code Issues Projects Releases Wiki Activity

Clean up unnecessary profile events

Browse Source 
Summary: public

There were some old markers that are now automatically inject and now are no longer necessary (+ one that was missing an end call :( ))

Reviewed By: javache

Differential Revision: D2625901

fb-gh-sync-id: 4c4c9d6b4e8e2b4bdb9c64fde01000b0ca2e9f47
This commit is contained in:
Tadeu Zagallo 2015-11-06 06:54:45 -08:00 committed by facebook-github-bot-4
parent c1ae4780ce
commit de1c0169fc
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
React/Base/RCTBatchedBridge.m
View File

@ -627,7 +627,6 @@ RCT_NOT_IMPLEMENTED(- (instancetype)initWithBundleURL:(__unused NSURL *)bundleUR
__weak RCTBatchedBridge *weakSelf = self; __weak RCTBatchedBridge *weakSelf = self;
[_javaScriptExecutor executeBlockOnJavaScriptQueue:^{ [_javaScriptExecutor executeBlockOnJavaScriptQueue:^{
RCTProfileEndFlowEvent(); RCTProfileEndFlowEvent();
RCTProfileBeginEvent(0, @"enqueue_call", nil);
RCTBatchedBridge *strongSelf = weakSelf; RCTBatchedBridge *strongSelf = weakSelf;
if (!strongSelf || !strongSelf.valid) { if (!strongSelf || !strongSelf.valid) {
@ -731,7 +730,8 @@ RCT_NOT_IMPLEMENTED(- (instancetype)initWithBundleURL:(__unused NSURL *)bundleUR
dispatch_block_t block = ^{ dispatch_block_t block = ^{
RCTProfileEndFlowEvent(); RCTProfileEndFlowEvent();
RCTProfileBeginEvent(0, RCTCurrentThreadName(), nil); NSString *threadName = RCTCurrentThreadName();
RCTProfileBeginEvent(0, threadName, nil);
NSOrderedSet *calls = [buckets objectForKey:queue]; NSOrderedSet *calls = [buckets objectForKey:queue];
@autoreleasepool { @autoreleasepool {

5
React/Modules/RCTUIManager.m
View File

@ -861,8 +861,6 @@ RCT_EXPORT_METHOD(findSubviewIn:(nonnull NSNumber *)reactTag atPoint:(CGPoint)po
- (void)batchDidComplete - (void)batchDidComplete
{ {
RCTProfileBeginEvent(0, @"[RCTUIManager batchDidComplete]", nil);
// Gather blocks to be executed now that all view hierarchy manipulations have // Gather blocks to be executed now that all view hierarchy manipulations have
// been completed (note that these may still take place before layout has finished) // been completed (note that these may still take place before layout has finished)
for (RCTComponentData *componentData in _componentDataByName.allValues) { for (RCTComponentData *componentData in _componentDataByName.allValues) {
@ -893,9 +891,6 @@ RCT_EXPORT_METHOD(findSubviewIn:(nonnull NSNumber *)reactTag atPoint:(CGPoint)po
_nextLayoutAnimation = nil; _nextLayoutAnimation = nil;
} }
RCTProfileEndEvent(0, @"uimanager", @{
@"view_count": @(_viewRegistry.count),
});
[self flushUIBlocks]; [self flushUIBlocks];
} }