From de1c0169fcd46f51f2ff7abdb7c68761aa77dfc2 Mon Sep 17 00:00:00 2001 From: Tadeu Zagallo Date: Fri, 6 Nov 2015 06:54:45 -0800 Subject: [PATCH] Clean up unnecessary profile events Summary: public There were some old markers that are now automatically inject and now are no longer necessary (+ one that was missing an end call :( )) Reviewed By: javache Differential Revision: D2625901 fb-gh-sync-id: 4c4c9d6b4e8e2b4bdb9c64fde01000b0ca2e9f47 --- React/Base/RCTBatchedBridge.m | 4 ++-- React/Modules/RCTUIManager.m | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/React/Base/RCTBatchedBridge.m b/React/Base/RCTBatchedBridge.m index 2a8fcc36c..944c3dfc9 100644 --- a/React/Base/RCTBatchedBridge.m +++ b/React/Base/RCTBatchedBridge.m @@ -627,7 +627,6 @@ RCT_NOT_IMPLEMENTED(- (instancetype)initWithBundleURL:(__unused NSURL *)bundleUR __weak RCTBatchedBridge *weakSelf = self; [_javaScriptExecutor executeBlockOnJavaScriptQueue:^{ RCTProfileEndFlowEvent(); - RCTProfileBeginEvent(0, @"enqueue_call", nil); RCTBatchedBridge *strongSelf = weakSelf; if (!strongSelf || !strongSelf.valid) { @@ -731,7 +730,8 @@ RCT_NOT_IMPLEMENTED(- (instancetype)initWithBundleURL:(__unused NSURL *)bundleUR dispatch_block_t block = ^{ RCTProfileEndFlowEvent(); - RCTProfileBeginEvent(0, RCTCurrentThreadName(), nil); + NSString *threadName = RCTCurrentThreadName(); + RCTProfileBeginEvent(0, threadName, nil); NSOrderedSet *calls = [buckets objectForKey:queue]; @autoreleasepool { diff --git a/React/Modules/RCTUIManager.m b/React/Modules/RCTUIManager.m index 44ac329e3..0f675a518 100644 --- a/React/Modules/RCTUIManager.m +++ b/React/Modules/RCTUIManager.m @@ -861,8 +861,6 @@ RCT_EXPORT_METHOD(findSubviewIn:(nonnull NSNumber *)reactTag atPoint:(CGPoint)po - (void)batchDidComplete { - RCTProfileBeginEvent(0, @"[RCTUIManager batchDidComplete]", nil); - // Gather blocks to be executed now that all view hierarchy manipulations have // been completed (note that these may still take place before layout has finished) for (RCTComponentData *componentData in _componentDataByName.allValues) { @@ -893,9 +891,6 @@ RCT_EXPORT_METHOD(findSubviewIn:(nonnull NSNumber *)reactTag atPoint:(CGPoint)po _nextLayoutAnimation = nil; } - RCTProfileEndEvent(0, @"uimanager", @{ - @"view_count": @(_viewRegistry.count), - }); [self flushUIBlocks]; }