status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

YellowBox" Only provide elevation style prop when running on Android 

Summary:
For unknown reasons, setting elevation: Number.MAX_VALUE causes remote debugging to hang on iOS (some sort of overflow maybe). Setting it to Number.MAX_SAFE_INTEGER fixes the iOS issue, but since elevation is an android-only style property we might as well remove it altogether for iOS.

See: https://github.com/facebook/react-native/issues/12223
Closes https://github.com/facebook/react-native/pull/12744

Differential Revision: D4684524

Pulled By: mkonicek

fbshipit-source-id: 7fb4f6da1c5c0cb437beff0e75122523e7233b72
This commit is contained in:
cailenmusselman 2017-03-09 15:16:57 -08:00 committed by Facebook Github Bot
parent 921b9ac53d
commit dd5ac841d2
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Libraries/ReactNative/YellowBox.js
View File

@ -394,16 +394,22 @@ const textColor = 'white';
const rowGutter = 1; const rowGutter = 1;
const rowHeight = 46; const rowHeight = 46;
// For unknown reasons, setting elevation: Number.MAX_VALUE causes remote debugging to
// hang on iOS (some sort of overflow maybe). Setting it to Number.MAX_SAFE_INTEGER fixes the iOS issue, but since
// elevation is an android-only style property we might as well remove it altogether for iOS.
// See: https://github.com/facebook/react-native/issues/12223
const elevation = Platform.OS === 'android' ? Number.MAX_SAFE_INTEGER : undefined;
var styles = StyleSheet.create({ var styles = StyleSheet.create({
fullScreen: { fullScreen: {
height: '100%', height: '100%',
elevation: Number.MAX_VALUE elevation: elevation
}, },
inspector: { inspector: {
backgroundColor: backgroundColor(0.95), backgroundColor: backgroundColor(0.95),
height: '100%', height: '100%',
paddingTop: 5, paddingTop: 5,
elevation: Number.MAX_VALUE elevation:elevation
}, },
inspectorButtons: { inspectorButtons: {
flexDirection: 'row', flexDirection: 'row',
@ -451,7 +457,7 @@ var styles = StyleSheet.create({
left: 0, left: 0,
right: 0, right: 0,
bottom: 0, bottom: 0,
elevation: Number.MAX_VALUE elevation: elevation
}, },
listRow: { listRow: {
backgroundColor: backgroundColor(0.95), backgroundColor: backgroundColor(0.95),