From dd5ac841d2d88d3d7c2270f835aa5d9f8bfac5c3 Mon Sep 17 00:00:00 2001 From: cailenmusselman Date: Thu, 9 Mar 2017 15:16:57 -0800 Subject: [PATCH] YellowBox" Only provide elevation style prop when running on Android Summary: For unknown reasons, setting elevation: Number.MAX_VALUE causes remote debugging to hang on iOS (some sort of overflow maybe). Setting it to Number.MAX_SAFE_INTEGER fixes the iOS issue, but since elevation is an android-only style property we might as well remove it altogether for iOS. See: https://github.com/facebook/react-native/issues/12223 Closes https://github.com/facebook/react-native/pull/12744 Differential Revision: D4684524 Pulled By: mkonicek fbshipit-source-id: 7fb4f6da1c5c0cb437beff0e75122523e7233b72 --- Libraries/ReactNative/YellowBox.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/Libraries/ReactNative/YellowBox.js b/Libraries/ReactNative/YellowBox.js index e8be755b0..2042431c3 100644 --- a/Libraries/ReactNative/YellowBox.js +++ b/Libraries/ReactNative/YellowBox.js @@ -394,16 +394,22 @@ const textColor = 'white'; const rowGutter = 1; const rowHeight = 46; +// For unknown reasons, setting elevation: Number.MAX_VALUE causes remote debugging to +// hang on iOS (some sort of overflow maybe). Setting it to Number.MAX_SAFE_INTEGER fixes the iOS issue, but since +// elevation is an android-only style property we might as well remove it altogether for iOS. +// See: https://github.com/facebook/react-native/issues/12223 +const elevation = Platform.OS === 'android' ? Number.MAX_SAFE_INTEGER : undefined; + var styles = StyleSheet.create({ fullScreen: { height: '100%', - elevation: Number.MAX_VALUE + elevation: elevation }, inspector: { backgroundColor: backgroundColor(0.95), height: '100%', paddingTop: 5, - elevation: Number.MAX_VALUE + elevation:elevation }, inspectorButtons: { flexDirection: 'row', @@ -451,7 +457,7 @@ var styles = StyleSheet.create({ left: 0, right: 0, bottom: 0, - elevation: Number.MAX_VALUE + elevation: elevation }, listRow: { backgroundColor: backgroundColor(0.95),