status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Update PR guidelines 

Reviewed By: mkonicek

Differential Revision:D3035945
Ninja: oss docs

fb-gh-sync-id: 5569d266330d5ecb232d16b5100e3f12717acf4c
shipit-source-id: 5569d266330d5ecb232d16b5100e3f12717acf4c
This commit is contained in:
Martin Konicek 2016-03-10 09:50:29 -08:00 committed by Facebook Github Bot 7
parent d24db57d8e
commit d71c05164c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/PullRequestGuidelines.md
View File

@ -1,4 +1,4 @@
Here are some tips on how you can help review pull requests:
Here are some tips on reviewing pull requests:
- Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Ask for it and link to the template.
- Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency with the rest of the code? If not, link to the style guide.
- Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Ask for it and link to the template. Add labels 'Needs revision' and 'Needs response from author'. Examples: [#6395](https://github.com/facebook/react-native/pull/6395), [#5637](https://github.com/facebook/react-native/pull/5637).
- Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'.