From d71c05164cc2526f3d3a04f484b8d10401de582c Mon Sep 17 00:00:00 2001 From: Martin Konicek Date: Thu, 10 Mar 2016 09:50:29 -0800 Subject: [PATCH] Update PR guidelines Reviewed By: mkonicek Differential Revision:D3035945 Ninja: oss docs fb-gh-sync-id: 5569d266330d5ecb232d16b5100e3f12717acf4c shipit-source-id: 5569d266330d5ecb232d16b5100e3f12717acf4c --- docs/PullRequestGuidelines.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/PullRequestGuidelines.md b/docs/PullRequestGuidelines.md index d4805c6d5..3e8b420ca 100644 --- a/docs/PullRequestGuidelines.md +++ b/docs/PullRequestGuidelines.md @@ -1,4 +1,4 @@ -Here are some tips on how you can help review pull requests: +Here are some tips on reviewing pull requests: -- Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Ask for it and link to the template. -- Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency with the rest of the code? If not, link to the style guide. \ No newline at end of file +- Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Ask for it and link to the template. Add labels 'Needs revision' and 'Needs response from author'. Examples: [#6395](https://github.com/facebook/react-native/pull/6395), [#5637](https://github.com/facebook/react-native/pull/5637). +- Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'.