status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

`[RCTShadowView isHidden]` was removed 

Summary:
It's unused.
Use `display` prop instead to control visiblity of the view.

Reviewed By: fkgozali

Differential Revision: D6888104

fbshipit-source-id: dd37a365033ec36bdfcfa305ec6a965a10dec2cd
This commit is contained in:
Valentin Shergin 2018-02-05 22:15:35 -08:00 committed by Facebook Github Bot
parent 9dfa2e7f3c
commit c19bc79688
2 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
React/Modules/RCTUIManager.m
View File

@ -496,7 +496,6 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation)
UIUserInterfaceLayoutDirection layoutDirection;
BOOL isNew;
BOOL parentIsNew;
BOOL isHidden;
} RCTFrameData;
// Construct arrays then hand off to main thread
@ -513,7 +512,6 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation)
shadowView.layoutDirection,
shadowView.isNewView,
shadowView.superview.isNewView,
shadowView.isHidden,
};
}
}
@ -570,7 +568,6 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation)
UIView *view = viewRegistry[reactTag];
CGRect frame = frameData.frame;
BOOL isHidden = frameData.isHidden;
UIUserInterfaceLayoutDirection layoutDirection = frameData.layoutDirection;
BOOL isNew = frameData.isNew;
RCTLayoutAnimation *updatingLayoutAnimation = isNew ? nil : layoutAnimationGroup.updatingLayoutAnimation;
@ -588,10 +585,6 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation)
}
};
if (view.isHidden != isHidden) {
view.hidden = isHidden;
}
if (view.reactLayoutDirection != layoutDirection) {
view.reactLayoutDirection = layoutDirection;
}

6
React/Views/RCTShadowView.h
View File

@ -70,12 +70,6 @@ typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, UIView *> *viewRegistry
*/
@property (nonatomic, assign, getter=isNewView) BOOL newView;
/**
* isHidden - RCTUIManager uses this to determine whether or not the UIView should be hidden. Useful if the
* ShadowView determines that its UIView will be clipped and wants to hide it.
*/
@property (nonatomic, assign, getter=isHidden) BOOL hidden;
/**
* Computed layout direction of the view.
*/