From c19bc7968855e85758df9e1a47dc2a52e69668ed Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Mon, 5 Feb 2018 22:15:35 -0800 Subject: [PATCH] `[RCTShadowView isHidden]` was removed Summary: It's unused. Use `display` prop instead to control visiblity of the view. Reviewed By: fkgozali Differential Revision: D6888104 fbshipit-source-id: dd37a365033ec36bdfcfa305ec6a965a10dec2cd --- React/Modules/RCTUIManager.m | 7 ------- React/Views/RCTShadowView.h | 6 ------ 2 files changed, 13 deletions(-) diff --git a/React/Modules/RCTUIManager.m b/React/Modules/RCTUIManager.m index 5ac1fa985..17127c726 100644 --- a/React/Modules/RCTUIManager.m +++ b/React/Modules/RCTUIManager.m @@ -496,7 +496,6 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation) UIUserInterfaceLayoutDirection layoutDirection; BOOL isNew; BOOL parentIsNew; - BOOL isHidden; } RCTFrameData; // Construct arrays then hand off to main thread @@ -513,7 +512,6 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation) shadowView.layoutDirection, shadowView.isNewView, shadowView.superview.isNewView, - shadowView.isHidden, }; } } @@ -570,7 +568,6 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation) UIView *view = viewRegistry[reactTag]; CGRect frame = frameData.frame; - BOOL isHidden = frameData.isHidden; UIUserInterfaceLayoutDirection layoutDirection = frameData.layoutDirection; BOOL isNew = frameData.isNew; RCTLayoutAnimation *updatingLayoutAnimation = isNew ? nil : layoutAnimationGroup.updatingLayoutAnimation; @@ -588,10 +585,6 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation) } }; - if (view.isHidden != isHidden) { - view.hidden = isHidden; - } - if (view.reactLayoutDirection != layoutDirection) { view.reactLayoutDirection = layoutDirection; } diff --git a/React/Views/RCTShadowView.h b/React/Views/RCTShadowView.h index 1d8ed8a4c..70d73aad6 100644 --- a/React/Views/RCTShadowView.h +++ b/React/Views/RCTShadowView.h @@ -70,12 +70,6 @@ typedef void (^RCTApplierBlock)(NSDictionary *viewRegistry */ @property (nonatomic, assign, getter=isNewView) BOOL newView; -/** - * isHidden - RCTUIManager uses this to determine whether or not the UIView should be hidden. Useful if the - * ShadowView determines that its UIView will be clipped and wants to hide it. - */ -@property (nonatomic, assign, getter=isHidden) BOOL hidden; - /** * Computed layout direction of the view. */