status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-06 06:34:01 +00:00
Code Issues Projects Releases Wiki Activity

Show columns in redboxes

Browse Source 
Reviewed By: foghina

Differential Revision: D3229814

fb-gh-sync-id: 0e1c3692e0780287d5e31dbd24fa3145eb0882ec
fbshipit-source-id: 0e1c3692e0780287d5e31dbd24fa3145eb0882ec
This commit is contained in:
David Aurelio 2016-04-28 03:57:18 -07:00 committed by Facebook Github Bot 1
parent f323b02eff
commit 8c1b773e4d
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java
View File

@ -123,7 +123,9 @@ import org.json.JSONObject;
StackFrame frame = mStack[position - 1];
FrameViewHolder holder = (FrameViewHolder) convertView.getTag();
holder.mMethodView.setText(frame.getMethod());
holder.mFileView.setText(frame.getFileName() + ":" + frame.getLine());
final int column = frame.getColumn();
final String columnString = column < 0 ? "" : ":" + column;
holder.mFileView.setText(frame.getFileName() + ":" + frame.getLine() + columnString);
return convertView;
}
}

2
ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java
View File

@ -119,7 +119,7 @@ import com.facebook.react.bridge.ReadableMap;
stackTrace[i].getFileName(),
stackTrace[i].getMethodName(),
stackTrace[i].getLineNumber(),
0);
-1);
}
return result;
}