From 8c1b773e4d81ef452a70ae073033d6cffd33c5eb Mon Sep 17 00:00:00 2001 From: David Aurelio Date: Thu, 28 Apr 2016 03:57:18 -0700 Subject: [PATCH] Show columns in redboxes Reviewed By: foghina Differential Revision: D3229814 fb-gh-sync-id: 0e1c3692e0780287d5e31dbd24fa3145eb0882ec fbshipit-source-id: 0e1c3692e0780287d5e31dbd24fa3145eb0882ec --- .../main/java/com/facebook/react/devsupport/RedBoxDialog.java | 4 +++- .../java/com/facebook/react/devsupport/StackTraceHelper.java | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java index 39e48fefe..e6b777e1b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/RedBoxDialog.java @@ -123,7 +123,9 @@ import org.json.JSONObject; StackFrame frame = mStack[position - 1]; FrameViewHolder holder = (FrameViewHolder) convertView.getTag(); holder.mMethodView.setText(frame.getMethod()); - holder.mFileView.setText(frame.getFileName() + ":" + frame.getLine()); + final int column = frame.getColumn(); + final String columnString = column < 0 ? "" : ":" + column; + holder.mFileView.setText(frame.getFileName() + ":" + frame.getLine() + columnString); return convertView; } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java index 5618ba78d..179c0c35d 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/StackTraceHelper.java @@ -119,7 +119,7 @@ import com.facebook.react.bridge.ReadableMap; stackTrace[i].getFileName(), stackTrace[i].getMethodName(), stackTrace[i].getLineNumber(), - 0); + -1); } return result; }