status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

remove hard dependency on JSGlobalContextRef in inspector interfaces 

Differential Revision: D6385923

fbshipit-source-id: 2f547b0dc1760f72fa8d7edc67327415069c648e
This commit is contained in:
Ben Nham 2017-11-27 07:05:20 -08:00 committed by Facebook Github Bot
parent 5f99b1a55f
commit 850efa8650
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ReactCommon/jschelpers/InspectorInterfaces.h
View File

@ -14,8 +14,6 @@
#include <string>
#include <vector>
#include <JavaScriptCore/JSBase.h>
namespace facebook {
namespace react {
@ -46,8 +44,8 @@ public:
// Note: not destructible!
class IInspector {
public:
virtual void registerGlobalContext(const std::string& title, const std::function<bool()> &checkIsInspectedRemote, JSGlobalContextRef ctx) = 0;
virtual void unregisterGlobalContext(JSGlobalContextRef ctx) = 0;
virtual void registerGlobalContext(const std::string& title, const std::function<bool()> &checkIsInspectedRemote, void* ctx) = 0;
virtual void unregisterGlobalContext(void* ctx) = 0;
virtual std::vector<InspectorPage> getPages() const = 0;
virtual std::unique_ptr<ILocalConnection> connect(int pageId, std::unique_ptr<IRemoteConnection> remote) = 0;