From 850efa86508b19d800ff8cbdc725402c006db1a2 Mon Sep 17 00:00:00 2001 From: Ben Nham Date: Mon, 27 Nov 2017 07:05:20 -0800 Subject: [PATCH] remove hard dependency on JSGlobalContextRef in inspector interfaces Differential Revision: D6385923 fbshipit-source-id: 2f547b0dc1760f72fa8d7edc67327415069c648e --- ReactCommon/jschelpers/InspectorInterfaces.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ReactCommon/jschelpers/InspectorInterfaces.h b/ReactCommon/jschelpers/InspectorInterfaces.h index abf92bf37..8c8767b8e 100644 --- a/ReactCommon/jschelpers/InspectorInterfaces.h +++ b/ReactCommon/jschelpers/InspectorInterfaces.h @@ -14,8 +14,6 @@ #include #include -#include - namespace facebook { namespace react { @@ -46,8 +44,8 @@ public: // Note: not destructible! class IInspector { public: - virtual void registerGlobalContext(const std::string& title, const std::function &checkIsInspectedRemote, JSGlobalContextRef ctx) = 0; - virtual void unregisterGlobalContext(JSGlobalContextRef ctx) = 0; + virtual void registerGlobalContext(const std::string& title, const std::function &checkIsInspectedRemote, void* ctx) = 0; + virtual void unregisterGlobalContext(void* ctx) = 0; virtual std::vector getPages() const = 0; virtual std::unique_ptr connect(int pageId, std::unique_ptr remote) = 0;