status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fabric: Removed ConcreteShadowNode specialized constructors 

Summary:
@public
Apparently we don't need them.

Reviewed By: mdvacca

Differential Revision: D8944766

fbshipit-source-id: e3b78f98d3d805ab0aaf5a167efeb7e058c0394e
This commit is contained in:
Valentin Shergin 2018-08-04 09:30:16 -07:00 committed by Facebook Github Bot
parent 67a79010ca
commit 682fd43f3b
1 changed files with 2 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h
View File

@ -28,6 +28,8 @@ class ConcreteShadowNode: public ShadowNode {
static_assert(std::is_base_of<Props, PropsT>::value, "PropsT must be a descendant of Props"); static_assert(std::is_base_of<Props, PropsT>::value, "PropsT must be a descendant of Props");
public: public:
using ShadowNode::ShadowNode;
using ConcreteProps = PropsT; using ConcreteProps = PropsT;
using SharedConcreteProps = std::shared_ptr<const PropsT>; using SharedConcreteProps = std::shared_ptr<const PropsT>;
using ConcreteEventEmitter = EventEmitterT; using ConcreteEventEmitter = EventEmitterT;
@ -51,36 +53,6 @@ public:
return defaultSharedProps; return defaultSharedProps;
} }
ConcreteShadowNode(
const Tag &tag,
const Tag &rootTag,
const SharedConcreteProps &props,
const SharedConcreteEventEmitter &eventEmitter,
const SharedShadowNodeSharedList &children,
const ShadowNodeCloneFunction &cloneFunction
):
ShadowNode(
tag,
rootTag,
(SharedProps)props,
eventEmitter,
children,
cloneFunction
) {};
ConcreteShadowNode(
const SharedConcreteShadowNode &shadowNode,
const SharedProps &props,
const SharedEventEmitter &eventEmitter,
const SharedShadowNodeSharedList &children
):
ShadowNode(
shadowNode,
(SharedProps)props,
eventEmitter,
children
) {}
ComponentName getComponentName() const override { ComponentName getComponentName() const override {
return ComponentName(concreteComponentName); return ComponentName(concreteComponentName);
} }