From 682fd43f3bac64553eb7cc6a06a853e21eaebe61 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Sat, 4 Aug 2018 09:30:16 -0700 Subject: [PATCH] Fabric: Removed ConcreteShadowNode specialized constructors Summary: @public Apparently we don't need them. Reviewed By: mdvacca Differential Revision: D8944766 fbshipit-source-id: e3b78f98d3d805ab0aaf5a167efeb7e058c0394e --- .../core/shadownode/ConcreteShadowNode.h | 32 ++----------------- 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h b/ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h index 01568d583..b722c1a5b 100644 --- a/ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h +++ b/ReactCommon/fabric/core/shadownode/ConcreteShadowNode.h @@ -28,6 +28,8 @@ class ConcreteShadowNode: public ShadowNode { static_assert(std::is_base_of::value, "PropsT must be a descendant of Props"); public: + using ShadowNode::ShadowNode; + using ConcreteProps = PropsT; using SharedConcreteProps = std::shared_ptr; using ConcreteEventEmitter = EventEmitterT; @@ -51,36 +53,6 @@ public: return defaultSharedProps; } - ConcreteShadowNode( - const Tag &tag, - const Tag &rootTag, - const SharedConcreteProps &props, - const SharedConcreteEventEmitter &eventEmitter, - const SharedShadowNodeSharedList &children, - const ShadowNodeCloneFunction &cloneFunction - ): - ShadowNode( - tag, - rootTag, - (SharedProps)props, - eventEmitter, - children, - cloneFunction - ) {}; - - ConcreteShadowNode( - const SharedConcreteShadowNode &shadowNode, - const SharedProps &props, - const SharedEventEmitter &eventEmitter, - const SharedShadowNodeSharedList &children - ): - ShadowNode( - shadowNode, - (SharedProps)props, - eventEmitter, - children - ) {} - ComponentName getComponentName() const override { return ComponentName(concreteComponentName); }