status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-27 17:54:48 +00:00
Code Issues Projects Releases Wiki Activity

Fix removal of ReactShadowNode

Browse Source 
Reviewed By: achen1

Differential Revision: D7323294

fbshipit-source-id: 411aa1bcd93cc4f9df78f64ceb0c0d8c127bc3b0
This commit is contained in:
David Vacca 2018-03-19 18:21:45 -07:00 committed by Facebook Github Bot
parent cc3d45d2e9
commit 5347ecfd29
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricReconciler.java
View File

@ -103,6 +103,9 @@ public class FabricReconciler {
indicesToRemove[indicesToRemoveIndex++] = j;
if (!addedTags.contains(nodeToRemove.getReactTag())) {
tagsToDelete.add(nodeToRemove.getReactTag());
// TODO: T26729293 since we are not cloning ReactShadowNode's we need to "manually" remove
// from the ReactShadowTree when one of the nodes is deleted in JS.
nodeToRemove.getParent().removeChildAt(j);
}
}