From 5347ecfd296cdc882c7c198e6489f7482f27a073 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Mon, 19 Mar 2018 18:21:45 -0700 Subject: [PATCH] Fix removal of ReactShadowNode Reviewed By: achen1 Differential Revision: D7323294 fbshipit-source-id: 411aa1bcd93cc4f9df78f64ceb0c0d8c127bc3b0 --- .../main/java/com/facebook/react/fabric/FabricReconciler.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricReconciler.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricReconciler.java index d60cfdaed..4ea5d143b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricReconciler.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricReconciler.java @@ -103,6 +103,9 @@ public class FabricReconciler { indicesToRemove[indicesToRemoveIndex++] = j; if (!addedTags.contains(nodeToRemove.getReactTag())) { tagsToDelete.add(nodeToRemove.getReactTag()); + // TODO: T26729293 since we are not cloning ReactShadowNode's we need to "manually" remove + // from the ReactShadowTree when one of the nodes is deleted in JS. + nodeToRemove.getParent().removeChildAt(j); } }