status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-14 18:36:35 +00:00
Code Issues Projects Releases Wiki Activity

Improve unlink on rnpm

Browse Source 
Summary:
We don't need to look for `thisDependency` as we already have it. Small improvement as I am working on other fixes.
Closes https://github.com/facebook/react-native/pull/11867

Differential Revision: D4411177

fbshipit-source-id: 1413eb5457cb4d7916ead90f438ffe158f644cad
This commit is contained in:
Mike Grabowski 2017-01-12 13:45:43 -08:00 committed by Facebook Github Bot
parent 6b1bc4ad74
commit 4969f26252
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
local-cli/link/unlink.js
View File

@ -113,19 +113,20 @@ function unlink(args, config) {
const allDependencies = getDependencyConfig(config, getProjectDependencies()); const allDependencies = getDependencyConfig(config, getProjectDependencies());
const otherDependencies = filter(allDependencies, d => d.name !== packageName); const otherDependencies = filter(allDependencies, d => d.name !== packageName);
const thisDependency = find(allDependencies, d => d.name === packageName);
const iOSDependencies = compact(otherDependencies.map(d => d.config.ios)); const iOSDependencies = compact(otherDependencies.map(d => d.config.ios));
const tasks = [ const tasks = [
() => promisify(thisDependency.config.commands.preunlink || commandStub), () => promisify(dependency.commands.preunlink || commandStub),
() => unlinkDependencyAndroid(project.android, dependency, packageName), () => unlinkDependencyAndroid(project.android, dependency, packageName),
() => unlinkDependencyIOS(project.ios, dependency, packageName, iOSDependencies), () => unlinkDependencyIOS(project.ios, dependency, packageName, iOSDependencies),
() => unlinkDependencyWindows(project.windows, dependency, packageName), () => unlinkDependencyWindows(project.windows, dependency, packageName),
() => promisify(thisDependency.config.commands.postunlink || commandStub) () => promisify(dependency.commands.postunlink || commandStub)
]; ];
return promiseWaterfall(tasks) return promiseWaterfall(tasks)
.then(() => { .then(() => {
// @todo move all these to `tasks` array, just like in
// link
const assets = difference( const assets = difference(
dependency.assets, dependency.assets,
flatten(allDependencies, d => d.assets) flatten(allDependencies, d => d.assets)