From 4969f26252bb8774bfefb7f3b3bd63e7f5415edd Mon Sep 17 00:00:00 2001 From: Mike Grabowski Date: Thu, 12 Jan 2017 13:45:43 -0800 Subject: [PATCH] Improve `unlink` on rnpm Summary: We don't need to look for `thisDependency` as we already have it. Small improvement as I am working on other fixes. Closes https://github.com/facebook/react-native/pull/11867 Differential Revision: D4411177 fbshipit-source-id: 1413eb5457cb4d7916ead90f438ffe158f644cad --- local-cli/link/unlink.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/local-cli/link/unlink.js b/local-cli/link/unlink.js index 99b66f20d..0ac7c8b8a 100644 --- a/local-cli/link/unlink.js +++ b/local-cli/link/unlink.js @@ -113,19 +113,20 @@ function unlink(args, config) { const allDependencies = getDependencyConfig(config, getProjectDependencies()); const otherDependencies = filter(allDependencies, d => d.name !== packageName); - const thisDependency = find(allDependencies, d => d.name === packageName); const iOSDependencies = compact(otherDependencies.map(d => d.config.ios)); const tasks = [ - () => promisify(thisDependency.config.commands.preunlink || commandStub), + () => promisify(dependency.commands.preunlink || commandStub), () => unlinkDependencyAndroid(project.android, dependency, packageName), () => unlinkDependencyIOS(project.ios, dependency, packageName, iOSDependencies), () => unlinkDependencyWindows(project.windows, dependency, packageName), - () => promisify(thisDependency.config.commands.postunlink || commandStub) + () => promisify(dependency.commands.postunlink || commandStub) ]; return promiseWaterfall(tasks) .then(() => { + // @todo move all these to `tasks` array, just like in + // link const assets = difference( dependency.assets, flatten(allDependencies, d => d.assets)