status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fabric: Shadow node shallowing was removed from preventive cloning in UIManager 

Summary:
@public
We do preventing cloning in UIManager especially to add a layer to Shadow Node source chain,
so apparently there is no point illuminate that by calling `shallowSourceNode`.

Reviewed By: fkgozali

Differential Revision: D8585163

fbshipit-source-id: 3743edc30bf2183c420fd79ce1e59d68ceaa278b
This commit is contained in:
Valentin Shergin 2018-06-22 11:54:01 -07:00 committed by Facebook Github Bot
parent 48b9a6f887
commit 483c45cff0
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ReactCommon/fabric/uimanager/FabricUIManager.cpp
View File

@ -234,7 +234,6 @@ void FabricUIManager::appendChild(const SharedShadowNode &parentShadowNode, cons
auto childComponentDescriptor = (*componentDescriptorRegistry_)[childShadowNode]; auto childComponentDescriptor = (*componentDescriptorRegistry_)[childShadowNode];
auto clonedChildShadowNode = childComponentDescriptor->cloneShadowNode(childShadowNode); auto clonedChildShadowNode = childComponentDescriptor->cloneShadowNode(childShadowNode);
auto nonConstClonedChildShadowNode = std::const_pointer_cast<ShadowNode>(clonedChildShadowNode); auto nonConstClonedChildShadowNode = std::const_pointer_cast<ShadowNode>(clonedChildShadowNode);
nonConstClonedChildShadowNode->shallowSourceNode();
componentDescriptor->appendChild(parentShadowNode, clonedChildShadowNode); componentDescriptor->appendChild(parentShadowNode, clonedChildShadowNode);
return; return;
} }