status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-01-26 17:30:25 +00:00
Code Issues Projects Releases Wiki Activity

Fabric: Temporary experimental integration between old and new UIManagers

Browse Source 
Summary:
@public
We need this to enable measuring, responder-chain management and another features powered by UIManager commands.
As soon we have Fabric specifc command-delivery pipeline this must be reverted.

Reviewed By: fkgozali

Differential Revision: D8552360

fbshipit-source-id: d56e12d38c32d8ad98cb230671bac1f35e87e647
This commit is contained in:
Valentin Shergin 2018-06-22 11:53:55 -07:00 committed by Facebook Github Bot
parent af75d93dad
commit 48b9a6f887
1 changed files with 64 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
React/Fabric/Mounting/RCTComponentViewRegistry.mm
View File

@ -10,6 +10,60 @@
#import <Foundation/NSMapTable.h>
#import <React/RCTAssert.h>
#define LEGACY_UIMANAGER_INTEGRATION_ENABLED 1
#ifdef LEGACY_UIMANAGER_INTEGRATION_ENABLED
#import <React/RCTUIManager.h>
#import <React/RCTBridge+Private.h>
/**
* Warning: This is a total hack and temporary solution.
* Unless we have a pure Fabric-based implementation of UIManager commands
* delivery pipeline, we have to leverage existing infra. This code tricks
* legacy UIManager by registering all Fabric-managed views in it,
* hence existing command-delivery infra can reach "foreign" views using
* the old pipeline.
*/
@interface RCTUIManager ()
- (NSMutableDictionary<NSNumber *, UIView *> *)viewRegistry;
@end
@interface RCTUIManager (Hack)
+ (void)registerView:(UIView *)view;
+ (void)unregisterView:(UIView *)view;
@end
@implementation RCTUIManager (Hack)
+ (void)registerView:(UIView *)view
{
if (!view) {
return;
}
RCTUIManager *uiManager = [[RCTBridge currentBridge] uiManager];
view.reactTag = @(view.tag);
[uiManager.viewRegistry setObject:view forKey:@(view.tag)];
}
+ (void)unregisterView:(UIView *)view
{
if (!view) {
return;
}
RCTUIManager *uiManager = [[RCTBridge currentBridge] uiManager];
view.reactTag = nil;
[uiManager.viewRegistry removeObjectForKey:@(view.tag)];
}
@end
#endif
const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 256;
@implementation RCTComponentViewRegistry {
@ -37,6 +91,11 @@ const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 256;
[self _dequeueComponentViewWithName:componentName];
componentView.tag = tag;
[_registry setObject:componentView forKey:(__bridge id)(void *)tag];
#ifdef LEGACY_UIMANAGER_INTEGRATION_ENABLED
[RCTUIManager registerView:componentView];
#endif
return componentView;
}
@ -45,6 +104,11 @@ const NSInteger RCTComponentViewRegistryRecyclePoolMaxSize = 256;
componentView:(UIView<RCTComponentViewProtocol> *)componentView
{
RCTAssertMainQueue();
#ifdef LEGACY_UIMANAGER_INTEGRATION_ENABLED
[RCTUIManager unregisterView:componentView];
#endif
[_registry removeObjectForKey:(__bridge id)(void *)tag];
componentView.tag = 0;
[self _enqueueComponentViewWithName:componentName componentView:componentView];