status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-26 16:10:58 +00:00
Code Issues Projects Releases Wiki Activity

Delete YGNode ctor w/arg per member

Browse Source 
Summary: It doesn't seem to be used internally, it hurts greppability, and there are setters for these properties as needed anyway.

Reviewed By: davidaurelio

Differential Revision: D8842084

fbshipit-source-id: f0275b490e585ea94df341c97c34b441ed91c4fb
This commit is contained in:
Scott Wolchok 2018-07-18 15:45:34 -07:00 committed by Facebook Github Bot
parent f05943de0a
commit 46fb04e746
2 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
ReactCommon/yoga/yoga/YGNode.cpp
View File

@ -292,38 +292,6 @@ YGNode::YGNode(const YGConfigRef newConfig) : YGNode() {
config_ = newConfig; config_ = newConfig;
} }
YGNode::YGNode(
void* context,
YGPrintFunc print,
bool hasNewLayout,
YGNodeType nodeType,
YGMeasureFunc measure,
YGBaselineFunc baseline,
YGDirtiedFunc dirtied,
YGStyle style,
const YGLayout& layout,
uint32_t lineIndex,
YGNodeRef owner,
const YGVector& children,
YGConfigRef config,
bool isDirty,
std::array<YGValue, 2> resolvedDimensions)
: context_(context),
print_(print),
hasNewLayout_(hasNewLayout),
nodeType_(nodeType),
measure_(measure),
baseline_(baseline),
dirtied_(dirtied),
style_(style),
layout_(layout),
lineIndex_(lineIndex),
owner_(owner),
children_(children),
config_(config),
isDirty_(isDirty),
resolvedDimensions_(resolvedDimensions) {}
YGNode& YGNode::operator=(const YGNode& node) { YGNode& YGNode::operator=(const YGNode& node) {
if (&node == this) { if (&node == this) {
return *this; return *this;

16
ReactCommon/yoga/yoga/YGNode.h
View File

@ -40,22 +40,6 @@ struct YGNode {
explicit YGNode(const YGConfigRef newConfig); explicit YGNode(const YGConfigRef newConfig);
YGNode(const YGNode& node); YGNode(const YGNode& node);
YGNode& operator=(const YGNode& node); YGNode& operator=(const YGNode& node);
YGNode(
void* context,
YGPrintFunc print,
bool hasNewLayout,
YGNodeType nodeType,
YGMeasureFunc measure,
YGBaselineFunc baseline,
YGDirtiedFunc dirtied,
YGStyle style,
const YGLayout& layout,
uint32_t lineIndex,
YGNodeRef owner,
const YGVector& children,
YGConfigRef config,
bool isDirty,
std::array<YGValue, 2> resolvedDimensions);
// Getters // Getters
void* getContext() const { void* getContext() const {