From 46fb04e7467d88b4f9760d86b6c08294dd4b9131 Mon Sep 17 00:00:00 2001 From: Scott Wolchok Date: Wed, 18 Jul 2018 15:45:34 -0700 Subject: [PATCH] Delete YGNode ctor w/arg per member Summary: It doesn't seem to be used internally, it hurts greppability, and there are setters for these properties as needed anyway. Reviewed By: davidaurelio Differential Revision: D8842084 fbshipit-source-id: f0275b490e585ea94df341c97c34b441ed91c4fb --- ReactCommon/yoga/yoga/YGNode.cpp | 32 -------------------------------- ReactCommon/yoga/yoga/YGNode.h | 16 ---------------- 2 files changed, 48 deletions(-) diff --git a/ReactCommon/yoga/yoga/YGNode.cpp b/ReactCommon/yoga/yoga/YGNode.cpp index 70dd655da..dda20a553 100644 --- a/ReactCommon/yoga/yoga/YGNode.cpp +++ b/ReactCommon/yoga/yoga/YGNode.cpp @@ -292,38 +292,6 @@ YGNode::YGNode(const YGConfigRef newConfig) : YGNode() { config_ = newConfig; } -YGNode::YGNode( - void* context, - YGPrintFunc print, - bool hasNewLayout, - YGNodeType nodeType, - YGMeasureFunc measure, - YGBaselineFunc baseline, - YGDirtiedFunc dirtied, - YGStyle style, - const YGLayout& layout, - uint32_t lineIndex, - YGNodeRef owner, - const YGVector& children, - YGConfigRef config, - bool isDirty, - std::array resolvedDimensions) - : context_(context), - print_(print), - hasNewLayout_(hasNewLayout), - nodeType_(nodeType), - measure_(measure), - baseline_(baseline), - dirtied_(dirtied), - style_(style), - layout_(layout), - lineIndex_(lineIndex), - owner_(owner), - children_(children), - config_(config), - isDirty_(isDirty), - resolvedDimensions_(resolvedDimensions) {} - YGNode& YGNode::operator=(const YGNode& node) { if (&node == this) { return *this; diff --git a/ReactCommon/yoga/yoga/YGNode.h b/ReactCommon/yoga/yoga/YGNode.h index c204d4600..cba72163f 100644 --- a/ReactCommon/yoga/yoga/YGNode.h +++ b/ReactCommon/yoga/yoga/YGNode.h @@ -40,22 +40,6 @@ struct YGNode { explicit YGNode(const YGConfigRef newConfig); YGNode(const YGNode& node); YGNode& operator=(const YGNode& node); - YGNode( - void* context, - YGPrintFunc print, - bool hasNewLayout, - YGNodeType nodeType, - YGMeasureFunc measure, - YGBaselineFunc baseline, - YGDirtiedFunc dirtied, - YGStyle style, - const YGLayout& layout, - uint32_t lineIndex, - YGNodeRef owner, - const YGVector& children, - YGConfigRef config, - bool isDirty, - std::array resolvedDimensions); // Getters void* getContext() const {