status-im/react-native
2
0
Fork 0
mirror of https://github.com/status-im/react-native.git synced 2025-02-23 06:38:13 +00:00
Code Issues Projects Releases Wiki Activity

Fabric: Fixed incorrect systrace marker in UIManagerBinding::dispatchEvent

Browse Source 
Summary: `SystraceSection` relies on RAII, so previously it measured only `if (eventTarget) {`'s body.

Reviewed By: mdvacca

Differential Revision: D13123047

fbshipit-source-id: 463fba783763f694b51325f98314d36b7da2f887
This commit is contained in:
Valentin Shergin 2018-11-27 20:58:28 -08:00 committed by Facebook Github Bot
parent 7197aa026b
commit 106de1201b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ReactCommon/fabric/uimanager/UIManagerBinding.cpp
View File

@ -68,10 +68,11 @@ void UIManagerBinding::dispatchEvent(
const EventTarget *eventTarget, const EventTarget *eventTarget,
const std::string &type, const std::string &type,
const folly::dynamic &payload) const { const folly::dynamic &payload) const {
SystraceSection s("UIManagerBinding::dispatchEvent");
auto eventTargetValue = jsi::Value::null(); auto eventTargetValue = jsi::Value::null();
if (eventTarget) { if (eventTarget) {
SystraceSection s("UIManagerBinding::JSIDispatchFabricEventToTarget");
auto &eventTargetWrapper = auto &eventTargetWrapper =
static_cast<const EventTargetWrapper &>(*eventTarget); static_cast<const EventTargetWrapper &>(*eventTarget);
eventTargetValue = eventTargetWrapper.instanceHandle.lock(runtime); eventTargetValue = eventTargetWrapper.instanceHandle.lock(runtime);