From 106de1201b08d20e6501415b38ba331d6f325f12 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Tue, 27 Nov 2018 20:58:28 -0800 Subject: [PATCH] Fabric: Fixed incorrect systrace marker in UIManagerBinding::dispatchEvent Summary: `SystraceSection` relies on RAII, so previously it measured only `if (eventTarget) {`'s body. Reviewed By: mdvacca Differential Revision: D13123047 fbshipit-source-id: 463fba783763f694b51325f98314d36b7da2f887 --- ReactCommon/fabric/uimanager/UIManagerBinding.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactCommon/fabric/uimanager/UIManagerBinding.cpp b/ReactCommon/fabric/uimanager/UIManagerBinding.cpp index d1fd3861f..870ceca96 100644 --- a/ReactCommon/fabric/uimanager/UIManagerBinding.cpp +++ b/ReactCommon/fabric/uimanager/UIManagerBinding.cpp @@ -68,10 +68,11 @@ void UIManagerBinding::dispatchEvent( const EventTarget *eventTarget, const std::string &type, const folly::dynamic &payload) const { + SystraceSection s("UIManagerBinding::dispatchEvent"); + auto eventTargetValue = jsi::Value::null(); if (eventTarget) { - SystraceSection s("UIManagerBinding::JSIDispatchFabricEventToTarget"); auto &eventTargetWrapper = static_cast(*eventTarget); eventTargetValue = eventTargetWrapper.instanceHandle.lock(runtime);