remove embeddedBundleURL

Reviewed By: fromcelticpark

Differential Revision: D6501542

fbshipit-source-id: c6f1adddc4e671f73195afde927face28ee79342
This commit is contained in:
Yujie Liu 2017-12-12 12:59:47 -08:00 committed by Facebook Github Bot
parent 914ae93336
commit 0b1e6444bb
5 changed files with 0 additions and 21 deletions

View File

@ -178,11 +178,6 @@ RCT_EXTERN NSString *RCTBridgeModuleNameForClass(Class bridgeModuleClass);
*/
@property (nonatomic, strong, readonly) NSURL *bundleURL;
/**
* URL of the embedded bundle of the bridge.
*/
@property (nonatomic, strong, readonly) NSURL *embeddedBundleURL;
/**
* The class of the executor currently being used. Changes to this value will
* take effect after the bridge is reloaded.

View File

@ -328,11 +328,6 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init)
// Sanitize the bundle URL
_bundleURL = [RCTConvert NSURL:_bundleURL.absoluteString];
if ([self.delegate respondsToSelector:@selector(embeddedBundleURLForBridge:)]) {
_embeddedBundleURL = [self.delegate embeddedBundleURLForBridge:self];
_embeddedBundleURL = [RCTConvert NSURL:_embeddedBundleURL.absoluteString];
}
self.batchedBridge = [[bridgeClass alloc] initWithParentBridge:self];
[self.batchedBridge start];

View File

@ -40,12 +40,6 @@
*/
- (NSArray<id<RCTBridgeModule>> *)extraModulesForBridge:(RCTBridge *)bridge;
/**
* The location of embedded bundle path, this should be a `file://` url
* pointing to a path inside the bundle resources, e.g. `file://..//main.jsbundle`.
*/
- (NSURL *)embeddedBundleURLForBridge:(RCTBridge *)bridge;
/**
* Configure whether the JSCExecutor created should use the system JSC API or
* alternative hooks provided. When returning YES from this method, you must have

View File

@ -178,7 +178,6 @@ struct RCTInstanceCallback : public InstanceCallback {
}
@synthesize bridgeDescription = _bridgeDescription;
@synthesize embeddedBundleURL = _embeddedBundleURL;
@synthesize loading = _loading;
@synthesize performanceLogger = _performanceLogger;
@synthesize valid = _valid;
@ -205,9 +204,6 @@ struct RCTInstanceCallback : public InstanceCallback {
launchOptions:bridge.launchOptions])) {
_parentBridge = bridge;
_performanceLogger = [bridge performanceLogger];
if ([bridge.delegate respondsToSelector:@selector(embeddedBundleURLForBridge:)]) {
_embeddedBundleURL = [bridge.delegate embeddedBundleURLForBridge:bridge];
}
registerPerformanceLoggerHooks(_performanceLogger);

View File

@ -26,7 +26,6 @@ RCT_EXPORT_MODULE()
{
return @{
@"scriptURL": self.bridge.bundleURL.absoluteString ?: @"",
@"embeddedBundleURL": self.bridge.embeddedBundleURL.absoluteString ?: @""
};
}