From 0b1e6444bbe27a0d5fd18efbcc1139b025bd236c Mon Sep 17 00:00:00 2001 From: Yujie Liu Date: Tue, 12 Dec 2017 12:59:47 -0800 Subject: [PATCH] remove embeddedBundleURL Reviewed By: fromcelticpark Differential Revision: D6501542 fbshipit-source-id: c6f1adddc4e671f73195afde927face28ee79342 --- React/Base/RCTBridge.h | 5 ----- React/Base/RCTBridge.m | 5 ----- React/Base/RCTBridgeDelegate.h | 6 ------ React/CxxBridge/RCTCxxBridge.mm | 4 ---- React/Modules/RCTSourceCode.m | 1 - 5 files changed, 21 deletions(-) diff --git a/React/Base/RCTBridge.h b/React/Base/RCTBridge.h index 99ad08522..abf7225d2 100644 --- a/React/Base/RCTBridge.h +++ b/React/Base/RCTBridge.h @@ -178,11 +178,6 @@ RCT_EXTERN NSString *RCTBridgeModuleNameForClass(Class bridgeModuleClass); */ @property (nonatomic, strong, readonly) NSURL *bundleURL; -/** - * URL of the embedded bundle of the bridge. - */ -@property (nonatomic, strong, readonly) NSURL *embeddedBundleURL; - /** * The class of the executor currently being used. Changes to this value will * take effect after the bridge is reloaded. diff --git a/React/Base/RCTBridge.m b/React/Base/RCTBridge.m index 13329f272..3995143a9 100644 --- a/React/Base/RCTBridge.m +++ b/React/Base/RCTBridge.m @@ -328,11 +328,6 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init) // Sanitize the bundle URL _bundleURL = [RCTConvert NSURL:_bundleURL.absoluteString]; - if ([self.delegate respondsToSelector:@selector(embeddedBundleURLForBridge:)]) { - _embeddedBundleURL = [self.delegate embeddedBundleURLForBridge:self]; - _embeddedBundleURL = [RCTConvert NSURL:_embeddedBundleURL.absoluteString]; - } - self.batchedBridge = [[bridgeClass alloc] initWithParentBridge:self]; [self.batchedBridge start]; diff --git a/React/Base/RCTBridgeDelegate.h b/React/Base/RCTBridgeDelegate.h index 1609544a9..78935112d 100644 --- a/React/Base/RCTBridgeDelegate.h +++ b/React/Base/RCTBridgeDelegate.h @@ -40,12 +40,6 @@ */ - (NSArray> *)extraModulesForBridge:(RCTBridge *)bridge; -/** - * The location of embedded bundle path, this should be a `file://` url - * pointing to a path inside the bundle resources, e.g. `file://..//main.jsbundle`. - */ -- (NSURL *)embeddedBundleURLForBridge:(RCTBridge *)bridge; - /** * Configure whether the JSCExecutor created should use the system JSC API or * alternative hooks provided. When returning YES from this method, you must have diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm index 202ff06f0..1cb78175e 100644 --- a/React/CxxBridge/RCTCxxBridge.mm +++ b/React/CxxBridge/RCTCxxBridge.mm @@ -178,7 +178,6 @@ struct RCTInstanceCallback : public InstanceCallback { } @synthesize bridgeDescription = _bridgeDescription; -@synthesize embeddedBundleURL = _embeddedBundleURL; @synthesize loading = _loading; @synthesize performanceLogger = _performanceLogger; @synthesize valid = _valid; @@ -205,9 +204,6 @@ struct RCTInstanceCallback : public InstanceCallback { launchOptions:bridge.launchOptions])) { _parentBridge = bridge; _performanceLogger = [bridge performanceLogger]; - if ([bridge.delegate respondsToSelector:@selector(embeddedBundleURLForBridge:)]) { - _embeddedBundleURL = [bridge.delegate embeddedBundleURLForBridge:bridge]; - } registerPerformanceLoggerHooks(_performanceLogger); diff --git a/React/Modules/RCTSourceCode.m b/React/Modules/RCTSourceCode.m index a7c274a00..4be46582a 100644 --- a/React/Modules/RCTSourceCode.m +++ b/React/Modules/RCTSourceCode.m @@ -26,7 +26,6 @@ RCT_EXPORT_MODULE() { return @{ @"scriptURL": self.bridge.bundleURL.absoluteString ?: @"", - @"embeddedBundleURL": self.bridge.embeddedBundleURL.absoluteString ?: @"" }; }