status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/docs/PullRequestGuidelines.md

5 lines
674 B
Markdown
Raw Normal View History

Update PR guidelines Reviewed By: mkonicek Differential Revision:D3035945 Ninja: oss docs fb-gh-sync-id: 5569d266330d5ecb232d16b5100e3f12717acf4c shipit-source-id: 5569d266330d5ecb232d16b5100e3f12717acf4c
2016-03-10 17:50:29 +00:00
Here are some tips on reviewing pull requests:
Update PR and issue templates and guidelines Summary:- Simplified the PR and Issue template to make them easier to read. - Add a very simple guide for reviewing PRs (cc bestander, feel free to add to this) Closes https://github.com/facebook/react-native/pull/6295 Differential Revision: D3011905 fb-gh-sync-id: 4929921690a6996e574e6b152a9dd41087cfffdc shipit-source-id: 4929921690a6996e574e6b152a9dd41087cfffdc
2016-03-04 17:14:32 +00:00
Update PR guidelines Reviewed By: mkonicek Differential Revision:D3035945 Ninja: oss docs fb-gh-sync-id: 5569d266330d5ecb232d16b5100e3f12717acf4c shipit-source-id: 5569d266330d5ecb232d16b5100e3f12717acf4c
2016-03-10 17:50:29 +00:00
- Does the PR miss info required in the [Pull request template](https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md)? Ask for it and link to the template. Add labels 'Needs revision' and 'Needs response from author'. Examples: [#6395](https://github.com/facebook/react-native/pull/6395), [#5637](https://github.com/facebook/react-native/pull/5637).
- Does the code style match the [Style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide), especially consistency with the rest of the codebase? If not, link to the style guide and add the label 'Needs revision'.