Compare commits

..
Author SHA1 Message Date
Michele Balistreri 3369498c9f bump version 2022-09-19 14:46:16 +02:00
Michele Balistreri 3bbdf13ef7 refactor the stored property 2022-09-19 14:21:29 +02:00
7 changed files with 15 additions and 128 deletions
+1 -1
View File
@@ -46,5 +46,5 @@ dependencies {
implementation 'com.facebook.react:react-native:+'
implementation 'org.bouncycastle:bcprov-jdk15on:1.60'
implementation 'org.apache.commons:commons-lang3:3.9'
implementation 'com.github.status-im.status-keycard-java:android:3.1.2'
implementation 'com.github.status-im.status-keycard-java:android:3.0.4'
}
@@ -56,17 +56,6 @@ public class RNStatusKeycardModule extends ReactContextBaseJavaModule implements
public void onHostDestroy() {
}
// Required for rn built in EventEmitter Calls.
@ReactMethod
public void addListener(String eventName) {
}
@ReactMethod
public void removeListeners(Integer count) {
}
@ReactMethod
public void nfcIsSupported(final Promise promise) {
if (smartCard != null) {
@@ -501,20 +490,6 @@ public class RNStatusKeycardModule extends ReactContextBaseJavaModule implements
}).start();
}
@ReactMethod
public void verifyCard(final String challenge, final Promise promise) {
new Thread(new Runnable() {
public void run() {
try {
promise.resolve(smartCard.verifyCard(challenge));
} catch (IOException | APDUException e) {
Log.d(TAG, e.getMessage());
promise.reject(e);
}
}
}).start();
}
// These three methods below are a nop on Android since NFC is always listening and we have a custom UI. They are needed in iOS to show the NFC dialog
@ReactMethod
public void startNFC(String prompt, final Promise promise) {
@@ -25,7 +25,6 @@ import java.util.HashMap;
import java.util.Iterator;
import im.status.keycard.applet.RecoverableSignature;
import im.status.keycard.applet.Certificate;
import im.status.keycard.globalplatform.GlobalPlatformCommandSet;
import im.status.keycard.io.APDUException;
import im.status.keycard.io.APDUResponse;
@@ -276,17 +275,7 @@ public class SmartCard extends BroadcastReceiver implements CardListener {
return cardInfo;
}
public WritableMap factoryResetPost() throws IOException, APDUException {
ApplicationInfo info = new ApplicationInfo(new KeycardCommandSet(this.cardChannel).select().checkOK().getData());
Log.i(TAG, "Selecting the factory reset Keycard applet succeeded");
WritableMap cardInfo = Arguments.createMap();
cardInfo.putBoolean("initialized?", info.isInitializedCard());
return cardInfo;
}
public WritableMap factoryResetFallback() throws IOException, APDUException {
public WritableMap factoryReset() throws IOException, APDUException {
GlobalPlatformCommandSet cmdSet = new GlobalPlatformCommandSet(this.cardChannel);
cmdSet.select().checkOK();
Log.i(TAG, "ISD selected");
@@ -298,30 +287,15 @@ public class SmartCard extends BroadcastReceiver implements CardListener {
Log.i(TAG, "Keycard applet instance deleted");
cmdSet.installKeycardApplet().checkOK();
Log.i(TAG, "Keycard applet instance re-installed");
Log.i(TAG, "Keycard applet instance re-installed");
return factoryResetPost();
}
ApplicationInfo info = new ApplicationInfo(new KeycardCommandSet(this.cardChannel).select().checkOK().getData());
Log.i(TAG, "Selecting the newly installed Keycard applet succeeded");
public WritableMap factoryReset() throws IOException, APDUException {
KeycardCommandSet cmdSet = new KeycardCommandSet(this.cardChannel);
APDUResponse resp = cmdSet.select();
WritableMap cardInfo = Arguments.createMap();
cardInfo.putBoolean("initialized?", info.isInitializedCard());
if (!resp.isOK()) {
return factoryResetFallback();
}
ApplicationInfo info = new ApplicationInfo(resp.getData());
if (!info.hasFactoryResetCapability()) {
return factoryResetFallback();
}
if (!cmdSet.factoryReset().isOK()) {
return factoryResetFallback();
}
return factoryResetPost();
return cardInfo;
}
public void deriveKey(final String path, final String pin) throws IOException, APDUException {
@@ -629,20 +603,6 @@ public class SmartCard extends BroadcastReceiver implements CardListener {
return sig;
}
public WritableMap verifyCard(final String challenge) throws IOException, APDUException {
KeycardCommandSet cmdSet = new KeycardCommandSet(this.cardChannel);
cmdSet.select().checkOK();
byte[] rawChallenge = Hex.decode(challenge);
byte[] data = cmdSet.identifyCard(rawChallenge).checkOK().getData();
byte[] caPubKey = Certificate.verifyIdentity(rawChallenge, data);
WritableMap out = Arguments.createMap();
out.putString("ca-public-key", Hex.toHexString(caPubKey));
out.putString("tlv-data", Hex.toHexString(data));
return out;
}
public void setPairings(ReadableMap newPairings) {
pairings.clear();
Iterator<Map.Entry<String,Object>> i = newPairings.getEntryIterator();
+6 -48
View File
@@ -89,17 +89,7 @@ class SmartCard {
resolve(true)
}
func factoryResetPost(channel: CardChannel, resolve: RCTPromiseResolveBlock, reject: RCTPromiseRejectBlock) throws -> Void {
let info = try ApplicationInfo(KeycardCommandSet(cardChannel: channel).select().checkOK().data)
os_log("Selecting the factory reset Keycard applet succeeded")
var cardInfo = [String: Any]()
cardInfo["initialized?"] = info.initializedCard
resolve(cardInfo)
}
func factoryResetFallback(channel: CardChannel, resolve: RCTPromiseResolveBlock, reject: RCTPromiseRejectBlock) throws -> Void {
func factoryReset(channel: CardChannel, resolve: RCTPromiseResolveBlock, reject: RCTPromiseRejectBlock) throws -> Void {
let cmdSet: GlobalPlatformCommandSet = GlobalPlatformCommandSet(cardChannel: channel);
try cmdSet.select().checkOK()
os_log("ISD selected")
@@ -113,45 +103,13 @@ class SmartCard {
try cmdSet.installKeycardInstance().checkOK()
os_log("Keycard applet instance re-installed")
try factoryResetPost(channel: channel, resolve: resolve, reject: reject)
}
let info = try ApplicationInfo(KeycardCommandSet(cardChannel: channel).select().checkOK().data)
os_log("Selecting the newly installed Keycard applet succeeded")
func factoryReset(channel: CardChannel, resolve: RCTPromiseResolveBlock, reject: RCTPromiseRejectBlock) throws -> Void {
let cmdSet = KeycardCommandSet(cardChannel: channel)
var resp = try cmdSet.select()
if (resp.sw != 0x9000) {
try factoryResetFallback(channel: channel, resolve: resolve, reject: reject)
return
}
var cardInfo = [String: Any]()
cardInfo["initialized?"] = info.initializedCard
let info = try ApplicationInfo(resp.data)
if (!info.hasFactoryResetCapability) {
try factoryResetFallback(channel: channel, resolve: resolve, reject: reject)
return
}
resp = try cmdSet.factoryReset()
if (resp.sw != 0x9000) {
try factoryResetFallback(channel: channel, resolve: resolve, reject: reject)
return
}
try factoryResetPost(channel: channel, resolve: resolve, reject: reject)
}
func verifyCard(channel: CardChannel, challenge: String, resolve: RCTPromiseResolveBlock, reject: RCTPromiseRejectBlock) throws {
let cmdSet = KeycardCommandSet(cardChannel: channel)
try cmdSet.select().checkOK()
let rawChallenge = hexToBytes(challenge);
let data = try cmdSet.identifyCard(challenge: rawChallenge).checkOK().data
let caPubKey = try Certificate.verifyIdentity(hash: rawChallenge, tlvData: data);
resolve([
"ca-public-key": bytesToHex(caPubKey ?? []),
"tlv-data": bytesToHex(data)
])
resolve(cardInfo)
}
func getApplicationInfo(channel: CardChannel, resolve: RCTPromiseResolveBlock, reject: RCTPromiseRejectBlock) throws -> Void {
-1
View File
@@ -13,7 +13,6 @@ RCT_EXTERN_METHOD(generateAndLoadKey:(NSString *)mnemonic pin:(NSString *)pin re
RCT_EXTERN_METHOD(saveMnemonic:(NSString *)mnemonic pin:(NSString *)pin resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
RCT_EXTERN_METHOD(getApplicationInfo:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
RCT_EXTERN_METHOD(factoryReset:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
RCT_EXTERN_METHOD(verifyCard:(NSString *)challenge resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
RCT_EXTERN_METHOD(deriveKey:(NSString *)path pin:(NSString *)pin resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
RCT_EXTERN_METHOD(exportKey:(NSString *)pin resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
RCT_EXTERN_METHOD(exportKeyWithPath:(NSString *)pin path:(NSString *)path resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject)
-5
View File
@@ -72,11 +72,6 @@ class StatusKeycard: RCTEventEmitter {
func factoryReset(_ resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
keycardInvokation(reject) { [unowned self] channel in try self.smartCard.factoryReset(channel: channel, resolve: resolve, reject: reject) }
}
@objc
func verifyCard(_ challenge: String, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
keycardInvokation(reject) { [unowned self] channel in try self.smartCard.verifyCard(channel: channel, challenge: challenge, resolve: resolve, reject: reject) }
}
@objc
func getApplicationInfo(_ resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
+1 -1
View File
@@ -1,7 +1,7 @@
{
"name": "react-native-status-keycard",
"homepage": "https://keycard.status.im/",
"version": "2.6.0",
"version": "2.5.38",
"description": "React Native library to interact with Status Keycard using NFC connection",
"main": "index.js",
"scripts": {