2
0
mirror of synced 2025-02-04 02:23:48 +00:00

1997 Commits

Author SHA1 Message Date
Ryan Grey
a8b4435abf Update ts types 2018-08-10 10:16:07 +01:00
Ryan Grey
ab42108234 Add auto call to done which awaits the listener before doing so
The idea is to catch any cases where the API user is not calling done manually.
This has the issue that we've modified pre-existing function to take a
Promisified callback instead of just a callback. Any user upgrading to a
version that contains this that does not read the upgrade guide and make
appropriate changes will:
- be passing a plain callback (not promisified)
- not be calling done
- may be performing async (something that triggers a later callback) in their
onNotificationDisplayed handler.

This all means that we will be auto calling `done` prior to them performing
any background work. This is exactly how things worked prior to these changes
so perhaps the user is no worse off.
2018-08-08 11:09:02 +01:00
Ryan Grey
0291605934 Protect against multiple calls to start/stop handling native methods 2018-08-06 15:22:15 +01:00
Ryan Grey
b53695ad52 Add RCTConverter+UIBackgroundFetchResult to handle auto conversion 2018-08-06 13:05:16 +01:00
Ryan Grey
5168f96a32 Only store completionHandlers on iOS native side when user adds listener
Note the following cases. This commit is catering for case 3:
1. User is listening for onNotificationDisplayed and is manually calling
the completionHandler
- manually called completionHandler is removed
- automatically called completionHandler is guarded against on iOS
native side

2. User is listening for onNotificationDisplayed and is not calling the
completionHandler:
- automatically called completionHandler is removed

3. User is not listening for onNotificationDisplayed
- On rn side we can only automatically call completionHandler if the
user _is_ listening. This means we need to detect if the user is
listening or not.
2018-08-06 13:04:44 +01:00
Ryan Grey
0d14a5e3b3 add notificationId to logging 2018-08-06 12:59:43 +01:00
Ryan Grey
fac0767d5d pass noop for android platform 2018-08-06 12:59:43 +01:00
Ryan Grey
b6885b0125 inject onNotificationDisplayed with completion handler 2018-08-06 12:59:43 +01:00
Ryan Grey
e6cd793f91 Add exported native function to complete handling of ios notification 2018-08-06 12:59:40 +01:00
Salakar
7a66c165ed [tests][iid] remove test focus 2018-07-15 00:47:00 +01:00
Salakar
8aac77b3ac [tests][iid] more coverage including change: getToken & deleteToken now have option args with defaults that use app.options.messagingSenderId as authorizedEntity and '*' as scope 2018-07-15 00:45:04 +01:00
Salakar
6a7d3ddc7a [types][iid] getToken & deleteToken now have option args with defaults that use app.options.messagingSenderId as authorizedEntity and '*' as scope 2018-07-15 00:44:20 +01:00
Salakar
aa12de3248 [js][iid] getToken & deleteToken now have option args with defaults that use app.options.messagingSenderId as authorizedEntity and '*' as scope 2018-07-15 00:43:12 +01:00
Salakar
947825c8ee 4.3.7 2018-07-14 23:35:04 +01:00
Salakar
d1783152dc [ios][storage] fix #739 2018-07-14 23:34:57 +01:00
Salakar
b29fbafc98 4.3.6 v4.3.6 2018-07-13 14:05:50 +01:00
Salakar
a88fa18b68 Merge remote-tracking branch 'origin/master' 2018-07-13 14:03:28 +01:00
Salakar
96b8372873 [android] fixes 1012 2018-07-13 14:03:20 +01:00
Salakar
01c274a2f1 4.3.5 v4.3.5 2018-07-11 14:43:50 +01:00
Salakar
94aed54a0a fix license format 2018-07-11 14:41:52 +01:00
Michael Diarmid
44907e3b14
Merge pull request #1293 from bilalsyed001/master
[Android] Fix getInitialLink() is NULL
2018-07-11 13:55:52 +01:00
Bilal Syed
c70af86e2e [Android] Fix getInitialLink() is NULL 2018-07-11 15:30:35 +03:00
Bilal Syed
98ca66294d
Merge pull request #1 from invertase/master
Taking updates
2018-07-11 15:17:04 +03:00
Salakar
3ca718c608 4.3.4 v4.3.4 2018-07-11 08:21:29 +01:00
Salakar
0671b2246f Merge remote-tracking branch 'origin/master' 2018-07-11 08:21:10 +01:00
Salakar
2e2913114a revert #869 to fix #1292 temporarily 2018-07-11 08:21:02 +01:00
Michael Diarmid
886efcaa62
Merge pull request #1276 from ifsnow/fix-android-schedule-date
[Android] Fix for setting past time in the scheduling.
2018-07-11 00:56:20 +01:00
Salakar
5be43f10a6 update npm ignore 2018-07-10 23:09:55 +01:00
Salakar
093d15aa67 4.3.3 v4.3.3 2018-07-10 23:07:46 +01:00
Salakar
8e492faf89 update npm ignore 2018-07-10 23:07:43 +01:00
Salakar
7c50c160e3 4.3.2 v4.3.2 2018-07-10 23:05:19 +01:00
Salakar
8886584bc0 update npm ignore 2018-07-10 23:05:12 +01:00
Salakar
e6b8c7f9f2 4.3.1 v4.3.1 2018-07-10 23:02:48 +01:00
Salakar
e4d42f15b8 update npm ignore 2018-07-10 23:02:34 +01:00
Salakar
82bb3ca3f7 4.3.0 2018-07-10 22:52:08 +01:00
Salakar
b3a675d964 [tests] misc project files v4.3.0 v4.3.x 2018-07-10 22:51:45 +01:00
Salakar
16a7e192f7 [types][flow] fix NativeDocumentChange.type -> should be enum to match other usage 2018-07-10 22:45:26 +01:00
Salakar
c35011145b [types][flow] add missing GetOptions type import 2018-07-10 22:44:27 +01:00
Salakar
c023a001a4 [types][flow] fix _forceResending type 2018-07-10 22:43:34 +01:00
Salakar
55a650e909 [tests][ios] lock Firebase SDK versions in Podfile 2018-07-10 22:17:50 +01:00
Salakar
b4f97c8f8c [tests][storage] content tests - need expanding - verified on console 2018-07-10 22:17:11 +01:00
Salakar
7e68d5eb11 [iid][ios] temporarily remove Messaging dependency for v4.3.0 release until an outcome is agreed on original PR #1215 2018-07-10 22:15:50 +01:00
Salakar
1d2757dc30 [crashlytics][ios] fix header imports 2018-07-10 21:37:56 +01:00
Salakar
5e9909954a [internals] check for string type else return early 2018-07-10 21:37:17 +01:00
Michael Diarmid
8733efa14f
Merge pull request #1287 from bilalsyed001/master
[iOS] Fix crash at unknown firebase url
2018-07-10 15:26:16 +01:00
Bilal Syed
ce9fdef7a1 handle error 2018-07-10 00:16:57 +03:00
Bilal Syed
b773717d1a [iOS] Fix crash at unknown firebase url 2018-07-09 22:56:45 +03:00
Salakar
5ad351b279 [storage][ios] misc 2018-07-09 17:46:14 +01:00
Salakar
af43576da5 [auth][android] fix for #1249 2018-07-09 13:19:02 +01:00
Salakar
ed9c06c80f [android][auth] reset force resending token if phone number changes 2018-07-08 16:39:35 +01:00