status-im/react-native-firebase
2
0
Fork 0
mirror of synced 2025-01-23 20:59:10 +00:00
Code Issues Projects Releases Wiki Activity

[js][database] todo comments

Browse Source
This commit is contained in:
Salakar 2017-08-11 15:58:42 +01:00
parent 425dfbcc43
commit 5e3cf0ad7f
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/firebase.js
View File

@ -63,6 +63,8 @@ class FirebaseCore {
const _name = (name || INTERNALS.STRINGS.DEFAULT_APP_NAME).toUpperCase(); const _name = (name || INTERNALS.STRINGS.DEFAULT_APP_NAME).toUpperCase();
// return an existing app if found // return an existing app if found
// todo flag as deprecated - no longer need to initialize native apps
// todo in v4 remove deprecation and throw an error
if (INTERNALS.APPS[_name]) return INTERNALS.APPS[_name]; if (INTERNALS.APPS[_name]) return INTERNALS.APPS[_name];
// only validate if app doesn't already exist // only validate if app doesn't already exist

1
lib/modules/database/reference.js
View File

@ -415,6 +415,7 @@ export default class Reference extends ReferenceBase {
return this.path; return this.path;
} }
// TODO should check query modifiers and if same app instance
/** /**
* Returns whether another Reference represent the same location and are from the * Returns whether another Reference represent the same location and are from the
* same instance of firebase.app.App - multiple firebase apps not currently supported. * same instance of firebase.app.App - multiple firebase apps not currently supported.