From 5e3cf0ad7ff73a5ba7900b76dacac8103b02f400 Mon Sep 17 00:00:00 2001 From: Salakar Date: Fri, 11 Aug 2017 15:58:42 +0100 Subject: [PATCH] [js][database] todo comments --- lib/firebase.js | 2 ++ lib/modules/database/reference.js | 1 + 2 files changed, 3 insertions(+) diff --git a/lib/firebase.js b/lib/firebase.js index 810957d6..85e02e77 100644 --- a/lib/firebase.js +++ b/lib/firebase.js @@ -63,6 +63,8 @@ class FirebaseCore { const _name = (name || INTERNALS.STRINGS.DEFAULT_APP_NAME).toUpperCase(); // return an existing app if found + // todo flag as deprecated - no longer need to initialize native apps + // todo in v4 remove deprecation and throw an error if (INTERNALS.APPS[_name]) return INTERNALS.APPS[_name]; // only validate if app doesn't already exist diff --git a/lib/modules/database/reference.js b/lib/modules/database/reference.js index 7a95aa46..3fcc3599 100644 --- a/lib/modules/database/reference.js +++ b/lib/modules/database/reference.js @@ -415,6 +415,7 @@ export default class Reference extends ReferenceBase { return this.path; } + // TODO should check query modifiers and if same app instance /** * Returns whether another Reference represent the same location and are from the * same instance of firebase.app.App - multiple firebase apps not currently supported.