Commit Graph

185 Commits

Author SHA1 Message Date
Mike Thompson d384da1c75 Alter wording in comments. 2016-06-24 21:31:12 +10:00
Mike Thompson a8b35cd9f1 Improve comment on function 2016-06-24 18:49:42 +10:00
Mike Thompson 5656f79f06 Improve warning message. 2016-06-24 18:26:45 +10:00
Mike Thompson 0b2bcbe65e Complete undo/redo work 2016-06-23 23:41:20 +10:00
Stuart Mitchell f4fb65037e Subscriptions sugar - changed to provide a singleton 2016-06-22 15:41:22 +12:00
Stuart Mitchell 5c7d4ea3d1 Bug Fix for undo tests 2016-06-22 14:30:15 +12:00
Stuart Mitchell addc55658e Bug fix for undo.cljs 2016-06-22 13:34:25 +12:00
Mike Thompson 9452998e0b WIP. undo test fails. 2016-06-22 10:54:41 +10:00
Mike Thompson d03ef7bc7a remover excessive whitespace 2016-06-14 22:45:57 +10:00
Mike Thompson af2fd0b21f Merge branch 'develop' of https://github.com/Day8/re-frame into develop
Conflicts:
	src/re_frame/subs.cljs
2016-06-14 21:14:49 +10:00
Mike Thompson 4741cd73d3 Better naming and comments. 2016-06-14 21:10:56 +10:00
Mike Thompson 6250c584da Add undo API 2016-06-14 21:09:21 +10:00
Mike Thompson 2822dc064a Put all undo related into a single namespace. Change the way middleware factories are done. 2016-06-14 21:08:32 +10:00
Stuart Mitchell 5a4d78ecc8 register-pure-sub: moved into correct namespace 2016-06-14 14:52:37 +12:00
Stuart Mitchell 1b698b3d8f register-pure: added code to enable spec checking of the fn args 2016-06-14 14:52:37 +12:00
Stuart Mitchell 48a1bda438 register-pure-sub: uses a function to do the work 2016-06-14 14:52:25 +12:00
Mike Thompson ea1e9e7745 Light improvements to comments in core. 2016-06-11 22:23:53 +10:00
Mike Thompson 5a214fc83b Fix bug which meant that post-event-callbacks were not called for `dispatch-sync` 2016-06-04 00:13:41 +10:00
Mike Thompson 9adf4cf40b Improve API comment 2016-06-03 12:58:06 +10:00
Mike Thompson 5684543b1a Introduce new API - `remove-post-event-callback` 2016-06-03 12:49:49 +10:00
Mike Thompson 053771ad9d Breaking change to logging 2016-05-31 07:50:49 +10:00
Mike Thompson 3d4e8cde8f Introduce de-duplicated subscriptions. 2016-05-29 23:23:17 +10:00
Mike Thompson c7fb38becf Error message made more generic 2016-05-29 22:48:18 +10:00
Mike Thompson e562b06880 Better router loop comments 2016-05-29 22:47:25 +10:00
Mike Thompson fe1b6bc729 improve trivial comment 2016-05-27 12:54:42 +10:00
Mike Thompson 45e0baee30 Get rid of code for Reagent pre-0.6.0. Plus add more comments. 2016-05-21 00:44:54 +10:00
Mike Thompson 5aafe09c1b Add link to alternative debug middleware 2016-05-21 00:44:16 +10:00
Mike Thompson 41593509be Improved comment 2016-05-20 22:36:35 +10:00
Daniel Compton 477459bae0 Fix grouping of debug/middleware 2016-05-05 12:40:02 +12:00
Daniel Compton c085ac8bb0 middleware/debug: Log a single line if app-db not changed by a handler
middleware/debug logs a group to the console even if there has been no
change to app-db. This makes it harder to tell if you've made a mistake
in refactoring, as the same log message will be shown whether or not
app-db is changing.

This change will log a single line if app-db is not changed by a handler

Fixes #166
2016-05-05 11:56:09 +12:00
Mike Thompson c182af1b59 Add comment on middleware 2016-03-22 14:11:21 +11:00
Mike Thompson 9b64df912d Actually remove log-ex. Commented out in last release. 2016-03-15 20:08:25 +11:00
Mike Thompson 9795a00ec7 Tweak debug middleware output so that exceptions don't get lost in collapsed Groups. 2016-03-14 23:32:24 +11:00
Mike Thompson f821c99858 Remove `log-ex` middleware - no longer needed 2016-03-14 21:00:33 +11:00
Mike Thompson 2c2c1c6612 Take out "experimental" comment near `on-changes`. It became official some time ago. 2016-02-26 23:01:54 +11:00
Mike Thompson 3246265483 Added one tick of extra pause when events have `:flush=dom` metadata. Previously, there were odd times when the pause wasn't enough. 2016-02-26 14:24:34 +11:00
Daniel Compton 41cf9951d8 Add tests for undo behaviour
Inspired by #149, this adds tests to cover the change that was made. It
also tests the redo logic.
2016-01-28 23:14:43 +13:00
Sergey Tselovalnikov bb78981e1d Fix behavior with large undo lists 2016-01-28 21:31:08 +13:00
Markus Bertheau 4115e410d6 Correct spelling 2016-01-23 18:07:20 +13:00
Markus Bertheau 4822688a62 Correct doc reference to handlers/register-base 2016-01-23 18:07:00 +13:00
Mike Thompson 00f706688a Make router work with 0.6.0 of reagent (and be backwards compatible) 2015-12-22 00:17:33 +11:00
Mike Thompson 8c01555a6a Further docs tweaks for v0.6.0 2015-12-09 07:40:47 +11:00
Mike Thompson 2ce82d9fda Add docs for new `add-post-event-callback`. Promote `on-change` to officially being a part of the API. 2015-12-08 08:19:59 +11:00
J. Pablo Fernández 4b84166566 Call the appropriate add-post-event-callback. For #118. 2015-12-06 19:10:32 +00:00
Mike Thompson 927d318626 First pass at providing what @pupeno needs for #118 2015-12-06 23:19:11 +11:00
Stephen C. Gilardi e77fc53e53 simplify state handling around resume 2015-11-06 23:04:45 -05:00
Stephen C. Gilardi 4a3d951568 direct call to -run-queue from resume
- this now happens in the :running state
  - just like a run-queue, but with an unconditional handling of the
    first item on the queue
- no need to trigger here
2015-11-06 23:03:07 -05:00
Stephen C. Gilardi fc9fa490a6 reorder to be the same as the order in the prototype 2015-11-06 23:01:55 -05:00
Stephen C. Gilardi bde07088a4 simplify names: pause, resume, regularize run-queue
- pause-run -> pause
- begin-resume -> resume
  - no longer a multi-step process
- begin-run -> run-queue
  - so all action function names match their keywords
2015-11-06 22:58:15 -05:00
Stephen C. Gilardi 38120c4913 fix a couple of comment typos 2015-11-06 22:50:50 -05:00