Tweak debug middleware output so that exceptions don't get lost in collapsed Groups.
This commit is contained in:
parent
accdc0a468
commit
9795a00ec7
11
CHANGES.md
11
CHANGES.md
|
@ -1,14 +1,19 @@
|
|||
## 0.7.0 (2016-NN-NN)
|
||||
## 0.7.0 (2016-03-14)
|
||||
|
||||
Breaking:
|
||||
- removed middleware `log-ex`. It is no longer needed because browsers now correctly report the
|
||||
throw site of re-thown exceptions. In the unlikely event that you absolutely still need it,
|
||||
the source for `log-ex`is still in `middleware.cljs`, commented out. Just transfer it to your project.
|
||||
the source for `log-ex` is still in `middleware.cljs`, commented out. Just transfer it to your project.
|
||||
|
||||
- `debug` middleware now produces slightly different output (to console). So no code will need to change,
|
||||
just your expectations of what you see in console. Previously all console output from an event handler was put
|
||||
into the one console group, which could lead to exceptions being hidden (down in a closed group).
|
||||
|
||||
Improvements:
|
||||
- added one tick of extra pause when events have `:flush=dom` metadata. Previously, there were odd times when
|
||||
the pause wasn't long enough to ensure redraws.
|
||||
- now compatable with Reagent 0.6.0 (but not fully tested) while remaining backwards compatible with Reagent v0.5.1
|
||||
- now compatible with Reagent 0.6.0 (but this not fully tested) while remaining backwards compatible with
|
||||
Reagent v0.5.1
|
||||
- [#138](https://github.com/Day8/re-frame/pull/138) Switch to using CircleCI and automated testing with Karma
|
||||
|
||||
Fixed:
|
||||
|
|
|
@ -36,6 +36,8 @@
|
|||
(reset! app-db new-db)))))))
|
||||
|
||||
|
||||
;; no longer needed
|
||||
|
||||
#_(defn log-ex
|
||||
"Middleware which catches and prints any handler-generated exceptions to console.
|
||||
Handlers are called from within a core.async go-loop, and core.async produces
|
||||
|
@ -64,11 +66,12 @@
|
|||
[handler]
|
||||
(fn debug-handler
|
||||
[db v]
|
||||
(group "re-frame event: " v)
|
||||
(log "Handling re-frame event: " v)
|
||||
(let [new-db (handler db v)
|
||||
diff (data/diff db new-db)]
|
||||
(log "only before: " (first diff))
|
||||
(log "only after : " (second diff))
|
||||
(group "clojure.data/diff for: " v)
|
||||
(log "only before: " (first diff))
|
||||
(log "only after : " (second diff))
|
||||
(groupEnd)
|
||||
new-db)))
|
||||
|
||||
|
|
Loading…
Reference in New Issue