Commit Graph

339 Commits

Author SHA1 Message Date
Mike Thompson af0cdf3d26 typos 2017-01-04 07:29:17 +11:00
Mike Thompson 46e0a60af1 Improve enrich comment with better description of example 2017-01-04 07:25:49 +11:00
Mike Thompson 1a6066348c Improve comment on enrich 2017-01-04 07:00:34 +11:00
Mike Thompson 209470e761 Correct the `:id` given to `on-change` interceptor (ie. fix cut and paste typo) 2016-12-28 16:13:02 +11:00
Daniel Compton 2210d6f129 Fix dynamic subscriptions
Fixes #296.
Thanks to @martinklepsch for #297.
2016-12-20 08:57:29 +13:00
Daniel Compton 7e25236067 Fix subs indentation 2016-12-20 08:57:29 +13:00
Daniel Compton b53062e859 Move reagent-id fn to re-frame.interop 2016-12-15 13:28:57 +13:00
Daniel Compton 0f8e95d70f Only require reagent.ratom in CLJS context
Reagent has a reagent.ratom CLJ file, but it is a macro file intended
for use from CLJS, not from a Clojure program.

Fixes #285
2016-12-15 11:54:18 +13:00
Daniel Compton bd18563f5d Tweak trim-v patch
- Add another test assertion
- Add changelog
- Tweak style of std interceptor to use dissoc-in
2016-12-12 15:40:59 +13:00
Oliver Hine ff7c175de0 making trim-v before/after symmetrical 2016-12-12 15:39:29 +13:00
Daniel Compton 52396f7518 Provide enrich interceptor with db coeffect
If no db effect was produced.

Fixes #278
2016-12-08 22:29:13 +13:00
Daniel Compton 5318a29ace Dispose of subscriptions that were created after restore fn
Fixes #223
2016-12-07 16:57:06 +13:00
Daniel Compton 0907659f8d Tweak clear-subscription-cache! docstring 2016-12-05 20:12:43 +13:00
Daniel Compton 7cf4441696 Fix spelling mistakes
From https://github.com/Day8/re-frame/pull/273
Thanks @Samstiles!
2016-12-05 17:59:28 +13:00
Daniel Compton 4d8a311134 Make sure that tracing is eliminated by Closure DCE 2016-11-28 22:12:17 +13:00
Daniel Compton 50e87fd5a6 Trace re-frame event lifecycle
Trace subs, FSM, events
Add tests for basic behaviour
2016-11-24 18:14:48 +13:00
Daniel Compton 769238acd4 Add tracing macros 2016-11-24 18:08:38 +13:00
Daniel Compton ff164beb8f Don't throw when subscribing to a non-existent sub
Fixes bug where we were logging if a sub didn't exist, but then trying
to create it still.
2016-11-24 17:57:41 +13:00
Daniel Compton 41990cf60f Add clear-subscription-cache! function 2016-11-06 19:41:51 +13:00
Daniel Compton a9569c2e8c Merge pull request #259 from Day8/fix-subs
Don't create subscriptions in reg-sub
2016-10-26 08:51:51 +13:00
Daniel Compton 0bb7b9c528
Spelling 2016-10-21 14:01:45 +13:00
Daniel Compton 9839b258cb
Don't create subscriptions in reg-sub
This commit fixes a bug where reg-sub created subscriptions and closed
over them when using the `:<- [:sub]` sugar. Now dependent subscriptions
aren't created until they are needed, and they will be cleaned up
correctly.
2016-10-21 09:56:20 +13:00
Daniel Compton fad4e7315b Add get-loggers function to get existing re-frame loggers 2016-10-17 10:30:22 +13:00
Daniel Compton c14935dea6
Spelling fixes 2016-10-13 17:44:29 +13:00
Daniel Compton 5486d2058f Call after interceptor with db coeffect, if no db effect is produced
after interceptors expect to always get a db value. If no db effect is
produced, then they may fail (for example schema validation on db if
no db is provided).

Fixes #239
2016-10-13 10:44:40 +13:00
Mike Thompson 55b1294c7d Weak attempt at improving a doc string. 2016-08-28 08:41:09 +10:00
Mike Thompson 797fc76006 Take out mention of middleware. 2016-08-27 23:54:07 +10:00
Mike Thompson 6c5a9bb880 Comment headings corrected 2016-08-27 23:45:47 +10:00
Mike Thompson 32336a20b5 Correct spelling. 2016-08-27 23:38:25 +10:00
Mike Thompson b0c0aa54ab Move low level handler registration for subs. 2016-08-27 23:18:40 +10:00
Mike Thompson 9ad9598d8f Remove example from code. It is already present in the docs. 2016-08-27 22:47:40 +10:00
Mike Thompson adec3b5459 This mod should have been a part of the previous checkin. 2016-08-27 22:47:15 +10:00
Mike Thompson 56de2a563e Stop `:name` being accepted for Interceptors. Should be `:id`.
`:name` was only ever valid for a short time during the alpha phases of 0.8.0
2016-08-27 22:22:35 +10:00
Mike Thompson bca5fd76db Remove old comment 2016-08-27 18:37:01 +10:00
Mike Thompson a5d3c6020f Merge branch 'develop' into re-frame-tweaks
# Conflicts:
#	src/re_frame/std_interceptors.cljc
2016-08-27 12:48:00 +10:00
Shaun Mahood 163c9388bf Fixing typos, spelling, and spacing on requires
General basic clean up.
I also changed begatted to begotten, which I think is correct but less
fun...
2016-08-26 12:48:24 -06:00
Daniel Compton 6a86431a44 Misc re-frame tweaks 2016-08-24 01:24:30 +12:00
Daniel Compton 6b21bfe714 Remove trailing spaces from console logging
console.log and family provide spaces between arguments, so we don't
need to add them in our console errors.
2016-08-22 16:06:15 +12:00
Mike Thompson 8cf42f57f5 Version 0.8.0 2016-08-19 18:20:21 +10:00
Mike Thompson cd55814cdf Undo previous stupidity 2016-08-19 15:41:56 +10:00
Mike Thompson 0514e06d0c Put in the right magic around `:advanced` Dead Code Elimination 2016-08-19 15:07:06 +10:00
Mike Thompson dd8bc250fb Fix up interceptors and get rid of pesky warnings. 2016-08-19 00:20:03 +10:00
Mike Thompson 3dc5c728c6 Ensure we get DCE (Dead code Elimination) 2016-08-18 23:27:52 +10:00
Mike Thompson bfb7da0e71 Remove private from registrar (we now need to access it in core to create restore function) 2016-08-18 17:13:53 +10:00
Mike Thompson 6f45cfc7c2 Subscription cache needed elsewhere, so no longer private 2016-08-18 11:58:42 +10:00
Mike Thompson 4bf54da69b Add make-restore-fn. I still need to figure out subscriptions. 2016-08-18 11:58:41 +10:00
Mike Thompson ca9513d0e7 Minor subs cleanup 2016-08-18 11:58:40 +10:00
Mike Thompson 3a8abed723 Clearer derefing of signals 2016-08-18 11:58:39 +10:00
Mike Thompson 49581cd96e Swap to using `:id` instead of `:name` (I thought I done this earlier) 2016-08-18 11:58:37 +10:00
Mike Thompson d10e87a279 Use help function more consistently 2016-08-18 11:58:36 +10:00