mirror of
https://github.com/status-im/nimbus-eth2.git
synced 2025-01-24 05:22:03 +00:00
4ed2e34a9e
This is a revamp of the attestation pool that cleans up several aspects of attestation processing as the network grows larger and block space becomes more precious. The aim is to better exploit the divide between attestation subnets and aggregations by keeping the two kinds separate until it's time to either produce a block or aggregate. This means we're no longer eagerly combining single-vote attestations, but rather wait until the last moment, and then try to add singles to all aggregates, including those coming from the network. Importantly, the branch improves on poor aggregate quality and poor attestation packing in cases where block space is running out. A basic greed scoring mechanism is used to select attestations for blocks - attestations are added based on how much many new votes they bring to the table. * Collect single-vote attestations separately and store these until it's time to make aggregates * Create aggregates based on single-vote attestations * Select _best_ aggregate rather than _first_ aggregate when on aggregation duty * Top up all aggregates with singles when it's time make the attestation cut, thus improving the chances of grabbing the best aggregates out there * Improve aggregation test coverage * Improve bitseq operations * Simplify aggregate signature creation * Make attestation cache temporary instead of storing it in attestation pool - most of the time, blocks are not being produced, no need to keep the data around * Remove redundant aggregate storage that was used only for RPC * Use tables to avoid some linear seeks when looking up attestation data * Fix long cleanup on large slot jumps * Avoid some pointers * Speed up iterating all attestations for a slot (fixes #2490)
18 KiB
18 KiB
AllTests-mainnet
Attestation pool processing [Preset: mainnet]
+ Attestations may arrive in any order [Preset: mainnet] OK
+ Attestations may overlap, bigger first [Preset: mainnet] OK
+ Attestations may overlap, smaller first [Preset: mainnet] OK
+ Attestations should be combined [Preset: mainnet] OK
+ Can add and retrieve simple attestations [Preset: mainnet] OK
+ Everyone voting for something different [Preset: mainnet] OK
+ Fork choice returns block with attestation OK
+ Fork choice returns latest block with no attestations OK
+ Trying to add a block twice tags the second as an error OK
+ Trying to add a duplicate block from an old pruned epoch is tagged as an error OK
+ Working with aggregates [Preset: mainnet] OK
OK: 11/11 Fail: 0/11 Skip: 0/11
Attestation validation [Preset: mainnet]
+ Validation sanity OK
OK: 1/1 Fail: 0/1 Skip: 0/1
Beacon chain DB [Preset: mainnet]
+ empty database [Preset: mainnet] OK
+ find ancestors [Preset: mainnet] OK
+ sanity check blocks [Preset: mainnet] OK
+ sanity check full states [Preset: mainnet] OK
+ sanity check full states, reusing buffers [Preset: mainnet] OK
+ sanity check genesis roundtrip [Preset: mainnet] OK
+ sanity check state diff roundtrip [Preset: mainnet] OK
+ sanity check states [Preset: mainnet] OK
+ sanity check states, reusing buffers [Preset: mainnet] OK
OK: 9/9 Fail: 0/9 Skip: 0/9
Beacon node
+ Compile OK
OK: 1/1 Fail: 0/1 Skip: 0/1
Beacon state [Preset: mainnet]
+ Smoke test initialize_beacon_state_from_eth1 [Preset: mainnet] OK
OK: 1/1 Fail: 0/1 Skip: 0/1
Block pool processing [Preset: mainnet]
+ Adding the same block twice returns a Duplicate error [Preset: mainnet] OK
+ Reverse order block add & get [Preset: mainnet] OK
+ Simple block add&get [Preset: mainnet] OK
+ getRef returns nil for missing blocks OK
+ loading tail block works [Preset: mainnet] OK
+ updateHead updates head and headState [Preset: mainnet] OK
+ updateStateData sanity [Preset: mainnet] OK
OK: 7/7 Fail: 0/7 Skip: 0/7
Block processing [Preset: mainnet]
+ Attestation gets processed at epoch [Preset: mainnet] OK
+ Passes from genesis state, empty block [Preset: mainnet] OK
+ Passes from genesis state, no block [Preset: mainnet] OK
+ Passes through epoch update, empty block [Preset: mainnet] OK
+ Passes through epoch update, no block [Preset: mainnet] OK
OK: 5/5 Fail: 0/5 Skip: 0/5
BlockRef and helpers [Preset: mainnet]
+ epochAncestor sanity [Preset: mainnet] OK
+ get_ancestor sanity [Preset: mainnet] OK
+ isAncestorOf sanity [Preset: mainnet] OK
OK: 3/3 Fail: 0/3 Skip: 0/3
BlockSlot and helpers [Preset: mainnet]
+ atSlot sanity [Preset: mainnet] OK
+ parent sanity [Preset: mainnet] OK
OK: 2/2 Fail: 0/2 Skip: 0/2
Eth2 specific discovery tests
+ Invalid attnets field OK
+ Subnet query OK
+ Subnet query after ENR update OK
OK: 3/3 Fail: 0/3 Skip: 0/3
Exit pool testing suite
+ addExitMessage/getAttesterSlashingMessage OK
+ addExitMessage/getProposerSlashingMessage OK
+ addExitMessage/getVoluntaryExitMessage OK
OK: 3/3 Fail: 0/3 Skip: 0/3
Fork Choice + Finality [Preset: mainnet]
+ fork_choice - testing finality #01 OK
+ fork_choice - testing finality #02 OK
+ fork_choice - testing no votes OK
+ fork_choice - testing with votes OK
OK: 4/4 Fail: 0/4 Skip: 0/4
Honest validator
+ General pubsub topics OK
+ Mainnet attestation topics OK
+ is_aggregator OK
OK: 3/3 Fail: 0/3 Skip: 0/3
Interop
+ Interop genesis OK
+ Interop signatures OK
+ Mocked start private key OK
OK: 3/3 Fail: 0/3 Skip: 0/3
Official - constants & config [Preset: mainnet]
+ BASE_REWARD_FACTOR 64 [Preset: mainnet] OK
+ BLS_WITHDRAWAL_PREFIX "0x00" [Preset: mainnet] OK
+ CHURN_LIMIT_QUOTIENT 65536 [Preset: mainnet] OK
CONFIG_NAME "mainnet" [Preset: mainnet] Skip
DEPOSIT_CHAIN_ID 1 [Preset: mainnet] Skip
DEPOSIT_CONTRACT_ADDRESS "0x00000000219ab540356cBB839Cbe05303d770 Skip
DEPOSIT_NETWORK_ID 1 [Preset: mainnet] Skip
+ DOMAIN_AGGREGATE_AND_PROOF "0x06000000" [Preset: mainnet] OK
+ DOMAIN_BEACON_ATTESTER "0x01000000" [Preset: mainnet] OK
+ DOMAIN_BEACON_PROPOSER "0x00000000" [Preset: mainnet] OK
+ DOMAIN_DEPOSIT "0x03000000" [Preset: mainnet] OK
+ DOMAIN_RANDAO "0x02000000" [Preset: mainnet] OK
+ DOMAIN_SELECTION_PROOF "0x05000000" [Preset: mainnet] OK
+ DOMAIN_VOLUNTARY_EXIT "0x04000000" [Preset: mainnet] OK
+ EFFECTIVE_BALANCE_INCREMENT 1000000000 [Preset: mainnet] OK
+ EJECTION_BALANCE 16000000000 [Preset: mainnet] OK
+ EPOCHS_PER_ETH1_VOTING_PERIOD 64 [Preset: mainnet] OK
+ EPOCHS_PER_HISTORICAL_VECTOR 65536 [Preset: mainnet] OK
+ EPOCHS_PER_RANDOM_SUBNET_SUBSCRIPTION 256 [Preset: mainnet] OK
+ EPOCHS_PER_SLASHINGS_VECTOR 8192 [Preset: mainnet] OK
ETH1_FOLLOW_DISTANCE 2048 [Preset: mainnet] Skip
GENESIS_DELAY 604800 [Preset: mainnet] Skip
GENESIS_FORK_VERSION "0x00000000" [Preset: mainnet] Skip
+ HISTORICAL_ROOTS_LIMIT 16777216 [Preset: mainnet] OK
+ HYSTERESIS_DOWNWARD_MULTIPLIER 1 [Preset: mainnet] OK
+ HYSTERESIS_QUOTIENT 4 [Preset: mainnet] OK
+ HYSTERESIS_UPWARD_MULTIPLIER 5 [Preset: mainnet] OK
+ INACTIVITY_PENALTY_QUOTIENT 67108864 [Preset: mainnet] OK
+ MAX_ATTESTATIONS 128 [Preset: mainnet] OK
+ MAX_ATTESTER_SLASHINGS 2 [Preset: mainnet] OK
+ MAX_COMMITTEES_PER_SLOT 64 [Preset: mainnet] OK
+ MAX_DEPOSITS 16 [Preset: mainnet] OK
+ MAX_EFFECTIVE_BALANCE 32000000000 [Preset: mainnet] OK
+ MAX_PROPOSER_SLASHINGS 16 [Preset: mainnet] OK
+ MAX_SEED_LOOKAHEAD 4 [Preset: mainnet] OK
+ MAX_VALIDATORS_PER_COMMITTEE 2048 [Preset: mainnet] OK
+ MAX_VOLUNTARY_EXITS 16 [Preset: mainnet] OK
+ MIN_ATTESTATION_INCLUSION_DELAY 1 [Preset: mainnet] OK
+ MIN_DEPOSIT_AMOUNT 1000000000 [Preset: mainnet] OK
+ MIN_EPOCHS_TO_INACTIVITY_PENALTY 4 [Preset: mainnet] OK
MIN_GENESIS_ACTIVE_VALIDATOR_COUNT 16384 [Preset: mainnet] Skip
MIN_GENESIS_TIME 1606824000 [Preset: mainnet] Skip
+ MIN_PER_EPOCH_CHURN_LIMIT 4 [Preset: mainnet] OK
+ MIN_SEED_LOOKAHEAD 1 [Preset: mainnet] OK
+ MIN_SLASHING_PENALTY_QUOTIENT 128 [Preset: mainnet] OK
+ MIN_VALIDATOR_WITHDRAWABILITY_DELAY 256 [Preset: mainnet] OK
+ PROPORTIONAL_SLASHING_MULTIPLIER 1 [Preset: mainnet] OK
+ PROPOSER_REWARD_QUOTIENT 8 [Preset: mainnet] OK
+ RANDOM_SUBNETS_PER_VALIDATOR 1 [Preset: mainnet] OK
+ SAFE_SLOTS_TO_UPDATE_JUSTIFIED 8 [Preset: mainnet] OK
+ SECONDS_PER_ETH1_BLOCK 14 [Preset: mainnet] OK
+ SECONDS_PER_SLOT 12 [Preset: mainnet] OK
+ SHARD_COMMITTEE_PERIOD 256 [Preset: mainnet] OK
+ SHUFFLE_ROUND_COUNT 90 [Preset: mainnet] OK
+ SLOTS_PER_EPOCH 32 [Preset: mainnet] OK
+ SLOTS_PER_HISTORICAL_ROOT 8192 [Preset: mainnet] OK
+ TARGET_AGGREGATORS_PER_COMMITTEE 16 [Preset: mainnet] OK
+ TARGET_COMMITTEE_SIZE 128 [Preset: mainnet] OK
+ VALIDATOR_REGISTRY_LIMIT 1099511627776 [Preset: mainnet] OK
+ WHISTLEBLOWER_REWARD_QUOTIENT 512 [Preset: mainnet] OK
OK: 51/60 Fail: 0/60 Skip: 9/60
PeerPool testing suite
+ Access peers by key test OK
+ Acquire from empty pool OK
+ Acquire/Sorting and consistency test OK
+ Delete peer on release text OK
+ Iterators test OK
+ Peer lifetime test OK
+ Safe/Clear test OK
+ Score check test OK
+ Space tests OK
+ addPeer() test OK
+ addPeerNoWait() test OK
+ deletePeer() test OK
OK: 12/12 Fail: 0/12 Skip: 0/12
SSZ dynamic navigator
+ navigating fields OK
OK: 1/1 Fail: 0/1 Skip: 0/1
SSZ navigator
+ basictype OK
+ lists with max size OK
+ simple object fields OK
OK: 3/3 Fail: 0/3 Skip: 0/3
Slashing Protection DB - Interchange [Preset: mainnet]
+ Smoke test - Complete format - Invalid database is refused [Preset: mainnet] OK
+ Smoke test - Complete format [Preset: mainnet] OK
OK: 2/2 Fail: 0/2 Skip: 0/2
Slashing Protection DB - v1 and v2 migration [Preset: mainnet]
+ Minimal format migration [Preset: mainnet] OK
OK: 1/1 Fail: 0/1 Skip: 0/1
Slashing Protection DB [Preset: mainnet]
+ Attestation ordering #1698 OK
+ Empty database [Preset: mainnet] OK
+ SP for block proposal - backtracking append OK
+ SP for block proposal - linear append OK
+ SP for same epoch attestation target - linear append OK
+ SP for surrounded attestations OK
+ SP for surrounding attestations OK
+ Test valid attestation #1699 OK
OK: 8/8 Fail: 0/8 Skip: 0/8
Spec datatypes
+ Graffiti bytes OK
OK: 1/1 Fail: 0/1 Skip: 0/1
Spec helpers
+ integer_squareroot OK
OK: 1/1 Fail: 0/1 Skip: 0/1
Sync protocol
+ Compile OK
OK: 1/1 Fail: 0/1 Skip: 0/1
Zero signature sanity checks
+ SSZ serialization roundtrip of SignedBeaconBlockHeader OK
OK: 1/1 Fail: 0/1 Skip: 0/1
[Unit - Spec - Block processing] Attestations [Preset: mainnet]
+ Valid attestation OK
+ Valid attestation from previous epoch OK
OK: 2/2 Fail: 0/2 Skip: 0/2
[Unit - Spec - Block processing] Deposits [Preset: mainnet]
+ Deposit at MAX_EFFECTIVE_BALANCE balance (32 ETH) OK
+ Deposit over MAX_EFFECTIVE_BALANCE balance (32 ETH) OK
+ Deposit under MAX_EFFECTIVE_BALANCE balance (32 ETH) OK
+ Invalid deposit at MAX_EFFECTIVE_BALANCE balance (32 ETH) OK
+ Validator top-up OK
OK: 5/5 Fail: 0/5 Skip: 0/5
[Unit - Spec - Epoch processing] Justification and Finalization [Preset: mainnet]
+ Rule I - 234 finalization with enough support OK
+ Rule I - 234 finalization without support OK
+ Rule II - 23 finalization with enough support OK
+ Rule II - 23 finalization without support OK
+ Rule III - 123 finalization with enough support OK
+ Rule III - 123 finalization without support OK
+ Rule IV - 12 finalization with enough support OK
+ Rule IV - 12 finalization without support OK
OK: 8/8 Fail: 0/8 Skip: 0/8
chain DAG finalization tests [Preset: mainnet]
+ init with gaps [Preset: mainnet] OK
OK: 1/1 Fail: 0/1 Skip: 0/1
hash
+ HashArray OK
+ HashList OK
OK: 2/2 Fail: 0/2 Skip: 0/2
state diff tests [Preset: mainnet]
+ random slot differences [Preset: mainnet] OK
OK: 1/1 Fail: 0/1 Skip: 0/1
---TOTAL--- OK: 157/166 Fail: 0/166 Skip: 9/166