nimbus-eth2/beacon_chain
Jacek Sieka a7a65bce42
disentangle eth2 types from the ssz library (#2785)
* reorganize ssz dependencies

This PR continues the work in
https://github.com/status-im/nimbus-eth2/pull/2646,
https://github.com/status-im/nimbus-eth2/pull/2779 as well as past
issues with serialization and type, to disentangle SSZ from eth2 and at
the same time simplify imports and exports with a structured approach.

The principal idea here is that when a library wants to introduce SSZ
support, they do so via 3 files:

* `ssz_codecs` which imports and reexports `codecs` - this covers the
basic byte conversions and ensures no overloads get lost
* `xxx_merkleization` imports and exports `merkleization` to specialize
and get access to `hash_tree_root` and friends
* `xxx_ssz_serialization` imports and exports `ssz_serialization` to
specialize ssz for a specific library

Those that need to interact with SSZ always import the `xxx_` versions
of the modules and never `ssz` itself so as to keep imports simple and
safe.

This is similar to how the REST / JSON-RPC serializers are structured in
that someone wanting to serialize spec types to REST-JSON will import
`eth2_rest_serialization` and nothing else.

* split up ssz into a core library that is independendent of eth2 types
* rename `bytes_reader` to `codec` to highlight that it contains coding
and decoding of bytes and native ssz types
* remove tricky List init overload that causes compile issues
* get rid of top-level ssz import
* reenable merkleization tests
* move some "standard" json serializers to spec
* remove `ValidatorIndex` serialization for now
* remove test_ssz_merkleization
* add tests for over/underlong byte sequences
* fix broken seq[byte] test - seq[byte] is not an SSZ type

There are a few things this PR doesn't solve:

* like #2646 this PR is weak on how to handle root and other
dontSerialize fields that "sometimes" should be computed - the same
problem appears in REST / JSON-RPC etc

* Fix a build problem on macOS

* Another way to fix the macOS builds

Co-authored-by: Zahary Karadjov <zahary@gmail.com>
2021-08-18 20:57:58 +02:00
..
consensus_object_pools disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
eth1 disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
fork_choice rework spec imports (#2779) 2021-08-12 13:08:20 +00:00
gossip_processing disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
networking disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
rpc disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
spec disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
ssz disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
sync disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
validator_client disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
validators disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
.gitignore Rename binaries; Mimic the original repo layout in the distribution 2020-11-09 11:38:52 +02:00
beacon_chain_db.nim disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
beacon_chain_db_immutable.nim disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
beacon_clock.nim rework spec imports (#2779) 2021-08-12 13:08:20 +00:00
beacon_node_common.nim altair topic switching (#2767) 2021-08-09 12:54:45 +00:00
beacon_node_status.nim EH cleanup (#2455) 2021-03-26 07:52:01 +01:00
beacon_node_types.nim rework spec imports (#2779) 2021-08-12 13:08:20 +00:00
conf.nim rework spec imports (#2779) 2021-08-12 13:08:20 +00:00
extras.nim use ForkedHashedBeaconState in StateData (#2634) 2021-06-11 20:51:46 +03:00
filepath.nim EH cleanup (#2455) 2021-03-26 07:52:01 +01:00
interop.nim disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
nimbus_beacon_node.nim disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
nimbus_beacon_node.nim.cfg remove remaining traces of nim-prompt 2021-08-16 21:56:50 +03:00
nimbus_binary_common.nim rework spec imports (#2779) 2021-08-12 13:08:20 +00:00
nimbus_signing_process.nim rework spec imports (#2779) 2021-08-12 13:08:20 +00:00
nimbus_validator_client.nim REST API client, JSON-RPC cleanups (#2756) 2021-08-03 17:17:11 +02:00
nimbus_validator_client.nim.cfg remove remaining traces of nim-prompt 2021-08-16 21:56:50 +03:00
sszdump.nim disentangle eth2 types from the ssz library (#2785) 2021-08-18 20:57:58 +02:00
statediff.nim rework spec imports (#2779) 2021-08-12 13:08:20 +00:00
statusbar.nim switch result = foo to expression return; unexport rest of logtrace symbols (#2788) 2021-08-17 09:51:39 +00:00
version.nim Merge remote-tracking branch 'origin/stable' into merge-stable 2021-08-09 13:14:28 +02:00