status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove an overly agressive assertion (#4759)

This commit is contained in:
zah 2023-03-21 23:35:22 +02:00 committed by GitHub
parent 813fddee8c
commit b8f2022668
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
beacon_chain/eth1/eth1_monitor.nim
View File

@ -1120,7 +1120,8 @@ proc processResponse[ELResponseType](
requests: openArray[Future[ELResponseType]], requests: openArray[Future[ELResponseType]],
idx: int) = idx: int) =
doAssert requests[idx].completed if not requests[idx].completed:
return
let status = try: requests[idx].read.status let status = try: requests[idx].read.status
except CatchableError: raiseAssert "checked above" except CatchableError: raiseAssert "checked above"
@ -1166,7 +1167,7 @@ proc sendNewPayload*(m: ELManager,
for idx, req in requests: for idx, req in requests:
if not req.finished: if not req.finished:
stillPending.add req stillPending.add req
elif not req.failed: elif req.completed:
responseProcessor.processResponse(m.elConnections, requests, idx) responseProcessor.processResponse(m.elConnections, requests, idx)
if responseProcessor.disagreementAlreadyDetected: if responseProcessor.disagreementAlreadyDetected:
@ -1273,7 +1274,7 @@ proc forkchoiceUpdated*(m: ELManager,
for idx, req in requests: for idx, req in requests:
if not req.finished: if not req.finished:
stillPending.add req stillPending.add req
elif not req.failed: elif req.completed:
responseProcessor.processResponse(m.elConnections, requests, idx) responseProcessor.processResponse(m.elConnections, requests, idx)
if responseProcessor.disagreementAlreadyDetected: if responseProcessor.disagreementAlreadyDetected: