From b8f2022668629067f0c465ef1af256747e601168 Mon Sep 17 00:00:00 2001 From: zah Date: Tue, 21 Mar 2023 23:35:22 +0200 Subject: [PATCH] Remove an overly agressive assertion (#4759) --- beacon_chain/eth1/eth1_monitor.nim | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/beacon_chain/eth1/eth1_monitor.nim b/beacon_chain/eth1/eth1_monitor.nim index 43425fe90..00430589d 100644 --- a/beacon_chain/eth1/eth1_monitor.nim +++ b/beacon_chain/eth1/eth1_monitor.nim @@ -1120,7 +1120,8 @@ proc processResponse[ELResponseType]( requests: openArray[Future[ELResponseType]], idx: int) = - doAssert requests[idx].completed + if not requests[idx].completed: + return let status = try: requests[idx].read.status except CatchableError: raiseAssert "checked above" @@ -1166,7 +1167,7 @@ proc sendNewPayload*(m: ELManager, for idx, req in requests: if not req.finished: stillPending.add req - elif not req.failed: + elif req.completed: responseProcessor.processResponse(m.elConnections, requests, idx) if responseProcessor.disagreementAlreadyDetected: @@ -1273,7 +1274,7 @@ proc forkchoiceUpdated*(m: ELManager, for idx, req in requests: if not req.finished: stillPending.add req - elif not req.failed: + elif req.completed: responseProcessor.processResponse(m.elConnections, requests, idx) if responseProcessor.disagreementAlreadyDetected: