status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Enable 3 official EF spec tests (#883) 

* enable success_already_exited_recent, success_already_exited_long_ago, and valid_sig_but_forked_state EF spec tests
This commit is contained in:
tersec 2020-04-11 14:02:06 +00:00 committed by GitHub
parent afa08c8e3c
commit 8ebd0e166e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
FixtureAll-mainnet.md
View File

@ -80,10 +80,12 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
+ [Invalid] same_data OK + [Invalid] same_data OK
+ [Invalid] unsorted_att_1 OK + [Invalid] unsorted_att_1 OK
+ [Invalid] unsorted_att_2 OK + [Invalid] unsorted_att_2 OK
+ [Valid] success_already_exited_long_ago OK
+ [Valid] success_already_exited_recent OK
+ [Valid] success_double OK + [Valid] success_double OK
+ [Valid] success_surround OK + [Valid] success_surround OK
``` ```
OK: 16/16 Fail: 0/16 Skip: 0/16 OK: 18/18 Fail: 0/18 Skip: 0/18
## Official - Operations - Block header [Preset: mainnet] ## Official - Operations - Block header [Preset: mainnet]
```diff ```diff
+ [Invalid] invalid_parent_root OK + [Invalid] invalid_parent_root OK
@ -105,8 +107,9 @@ OK: 5/5 Fail: 0/5 Skip: 0/5
+ [Valid] new_deposit_over_max OK + [Valid] new_deposit_over_max OK
+ [Valid] new_deposit_under_max OK + [Valid] new_deposit_under_max OK
+ [Valid] success_top_up OK + [Valid] success_top_up OK
+ [Valid] valid_sig_but_forked_state OK
``` ```
OK: 10/10 Fail: 0/10 Skip: 0/10 OK: 11/11 Fail: 0/11 Skip: 0/11
## Official - Operations - Proposer slashing [Preset: mainnet] ## Official - Operations - Proposer slashing [Preset: mainnet]
```diff ```diff
+ [Invalid] identifier OK + [Invalid] identifier OK
@ -160,4 +163,4 @@ OK: 19/19 Fail: 0/19 Skip: 0/19
OK: 5/5 Fail: 0/5 Skip: 0/5 OK: 5/5 Fail: 0/5 Skip: 0/5
---TOTAL--- ---TOTAL---
OK: 110/110 Fail: 0/110 Skip: 0/110 OK: 113/113 Fail: 0/113 Skip: 0/113

9
FixtureAll-minimal.md
View File

@ -80,10 +80,12 @@ OK: 20/20 Fail: 0/20 Skip: 0/20
+ [Invalid] same_data OK + [Invalid] same_data OK
+ [Invalid] unsorted_att_1 OK + [Invalid] unsorted_att_1 OK
+ [Invalid] unsorted_att_2 OK + [Invalid] unsorted_att_2 OK
+ [Valid] success_already_exited_long_ago OK
+ [Valid] success_already_exited_recent OK
+ [Valid] success_double OK + [Valid] success_double OK
+ [Valid] success_surround OK + [Valid] success_surround OK
``` ```
OK: 16/16 Fail: 0/16 Skip: 0/16 OK: 18/18 Fail: 0/18 Skip: 0/18
## Official - Operations - Block header [Preset: minimal] ## Official - Operations - Block header [Preset: minimal]
```diff ```diff
+ [Invalid] invalid_parent_root OK + [Invalid] invalid_parent_root OK
@ -105,8 +107,9 @@ OK: 5/5 Fail: 0/5 Skip: 0/5
+ [Valid] new_deposit_over_max OK + [Valid] new_deposit_over_max OK
+ [Valid] new_deposit_under_max OK + [Valid] new_deposit_under_max OK
+ [Valid] success_top_up OK + [Valid] success_top_up OK
+ [Valid] valid_sig_but_forked_state OK
``` ```
OK: 10/10 Fail: 0/10 Skip: 0/10 OK: 11/11 Fail: 0/11 Skip: 0/11
## Official - Operations - Proposer slashing [Preset: minimal] ## Official - Operations - Proposer slashing [Preset: minimal]
```diff ```diff
+ [Invalid] identifier OK + [Invalid] identifier OK
@ -163,4 +166,4 @@ OK: 22/22 Fail: 0/22 Skip: 0/22
OK: 5/5 Fail: 0/5 Skip: 0/5 OK: 5/5 Fail: 0/5 Skip: 0/5
---TOTAL--- ---TOTAL---
OK: 113/113 Fail: 0/113 Skip: 0/113 OK: 116/116 Fail: 0/116 Skip: 0/116

1
tests/official/test_fixture_operations_attester_slashings.nim
View File

@ -74,7 +74,6 @@ suiteReport "Official - Operations - Attester slashing " & preset():
# which cases signature checks had been incorrectly passing. # which cases signature checks had been incorrectly passing.
const expected_failures = const expected_failures =
[ [
"success_already_exited_recent", "success_already_exited_long_ago",
# TODO: Regressions introduced by BLS v0.10.1 # TODO: Regressions introduced by BLS v0.10.1
"att1_duplicate_index_double_signed", "att2_duplicate_index_double_signed" "att1_duplicate_index_double_signed", "att2_duplicate_index_double_signed"
] ]

6
tests/official/test_fixture_operations_deposits.nim
View File

@ -61,11 +61,5 @@ proc runTest(identifier: string) =
`testImpl _ operations_deposits _ identifier`() `testImpl _ operations_deposits _ identifier`()
suiteReport "Official - Operations - Deposits " & preset(): suiteReport "Official - Operations - Deposits " & preset():
# TODO
const expected_failures = ["valid_sig_but_forked_state"]
for kind, path in walkDir(OperationsDepositsDir, true): for kind, path in walkDir(OperationsDepositsDir, true):
if path in expected_failures:
echo "Skipping test: ", path
continue
runTest(path) runTest(path)