From 8ebd0e166e5b802d5ff1507215add6caf7f56e81 Mon Sep 17 00:00:00 2001 From: tersec Date: Sat, 11 Apr 2020 14:02:06 +0000 Subject: [PATCH] Enable 3 official EF spec tests (#883) * enable success_already_exited_recent, success_already_exited_long_ago, and valid_sig_but_forked_state EF spec tests --- FixtureAll-mainnet.md | 9 ++++++--- FixtureAll-minimal.md | 9 ++++++--- .../test_fixture_operations_attester_slashings.nim | 1 - tests/official/test_fixture_operations_deposits.nim | 6 ------ 4 files changed, 12 insertions(+), 13 deletions(-) diff --git a/FixtureAll-mainnet.md b/FixtureAll-mainnet.md index 032a35006..d8333c6d1 100644 --- a/FixtureAll-mainnet.md +++ b/FixtureAll-mainnet.md @@ -80,10 +80,12 @@ OK: 20/20 Fail: 0/20 Skip: 0/20 + [Invalid] same_data OK + [Invalid] unsorted_att_1 OK + [Invalid] unsorted_att_2 OK ++ [Valid] success_already_exited_long_ago OK ++ [Valid] success_already_exited_recent OK + [Valid] success_double OK + [Valid] success_surround OK ``` -OK: 16/16 Fail: 0/16 Skip: 0/16 +OK: 18/18 Fail: 0/18 Skip: 0/18 ## Official - Operations - Block header [Preset: mainnet] ```diff + [Invalid] invalid_parent_root OK @@ -105,8 +107,9 @@ OK: 5/5 Fail: 0/5 Skip: 0/5 + [Valid] new_deposit_over_max OK + [Valid] new_deposit_under_max OK + [Valid] success_top_up OK ++ [Valid] valid_sig_but_forked_state OK ``` -OK: 10/10 Fail: 0/10 Skip: 0/10 +OK: 11/11 Fail: 0/11 Skip: 0/11 ## Official - Operations - Proposer slashing [Preset: mainnet] ```diff + [Invalid] identifier OK @@ -160,4 +163,4 @@ OK: 19/19 Fail: 0/19 Skip: 0/19 OK: 5/5 Fail: 0/5 Skip: 0/5 ---TOTAL--- -OK: 110/110 Fail: 0/110 Skip: 0/110 +OK: 113/113 Fail: 0/113 Skip: 0/113 diff --git a/FixtureAll-minimal.md b/FixtureAll-minimal.md index a49f4c133..1ae2933e9 100644 --- a/FixtureAll-minimal.md +++ b/FixtureAll-minimal.md @@ -80,10 +80,12 @@ OK: 20/20 Fail: 0/20 Skip: 0/20 + [Invalid] same_data OK + [Invalid] unsorted_att_1 OK + [Invalid] unsorted_att_2 OK ++ [Valid] success_already_exited_long_ago OK ++ [Valid] success_already_exited_recent OK + [Valid] success_double OK + [Valid] success_surround OK ``` -OK: 16/16 Fail: 0/16 Skip: 0/16 +OK: 18/18 Fail: 0/18 Skip: 0/18 ## Official - Operations - Block header [Preset: minimal] ```diff + [Invalid] invalid_parent_root OK @@ -105,8 +107,9 @@ OK: 5/5 Fail: 0/5 Skip: 0/5 + [Valid] new_deposit_over_max OK + [Valid] new_deposit_under_max OK + [Valid] success_top_up OK ++ [Valid] valid_sig_but_forked_state OK ``` -OK: 10/10 Fail: 0/10 Skip: 0/10 +OK: 11/11 Fail: 0/11 Skip: 0/11 ## Official - Operations - Proposer slashing [Preset: minimal] ```diff + [Invalid] identifier OK @@ -163,4 +166,4 @@ OK: 22/22 Fail: 0/22 Skip: 0/22 OK: 5/5 Fail: 0/5 Skip: 0/5 ---TOTAL--- -OK: 113/113 Fail: 0/113 Skip: 0/113 +OK: 116/116 Fail: 0/116 Skip: 0/116 diff --git a/tests/official/test_fixture_operations_attester_slashings.nim b/tests/official/test_fixture_operations_attester_slashings.nim index 6a02b7bc4..987512464 100644 --- a/tests/official/test_fixture_operations_attester_slashings.nim +++ b/tests/official/test_fixture_operations_attester_slashings.nim @@ -74,7 +74,6 @@ suiteReport "Official - Operations - Attester slashing " & preset(): # which cases signature checks had been incorrectly passing. const expected_failures = [ - "success_already_exited_recent", "success_already_exited_long_ago", # TODO: Regressions introduced by BLS v0.10.1 "att1_duplicate_index_double_signed", "att2_duplicate_index_double_signed" ] diff --git a/tests/official/test_fixture_operations_deposits.nim b/tests/official/test_fixture_operations_deposits.nim index 3f86e661d..633be6c68 100644 --- a/tests/official/test_fixture_operations_deposits.nim +++ b/tests/official/test_fixture_operations_deposits.nim @@ -61,11 +61,5 @@ proc runTest(identifier: string) = `testImpl _ operations_deposits _ identifier`() suiteReport "Official - Operations - Deposits " & preset(): - # TODO - const expected_failures = ["valid_sig_but_forked_state"] - for kind, path in walkDir(OperationsDepositsDir, true): - if path in expected_failures: - echo "Skipping test: ", path - continue runTest(path)