status-im/nimbus-eth2
2
0
Fork 0
mirror of https://github.com/status-im/nimbus-eth2.git synced 2025-02-05 03:03:26 +00:00
Code Issues Projects Releases Wiki Activity

use correct exception in parseCmdArg(enr.Record) (#5009)

Browse Source 
* use correct exception in `parseCmdArg(enr.Record)`

`parseCmdArg` is expected to raise `ValueError` but for `enr.Record` we
currently raise `ConfigurationError`. Change to `ValueError` instead.

* lint
This commit is contained in:
Etan Kissling 2023-05-31 21:07:06 +02:00 committed by GitHub
parent 021babd56d
commit 73b3f40e8d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
beacon_chain/conf.nim
View File

@ -1147,10 +1147,9 @@ func parseCmdArg*(T: type WalletName, input: string): T
func completeCmdArg*(T: type WalletName, input: string): seq[string] = func completeCmdArg*(T: type WalletName, input: string): seq[string] =
return @[] return @[]
proc parseCmdArg*(T: type enr.Record, p: string): T proc parseCmdArg*(T: type enr.Record, p: string): T {.raises: [ValueError].} =
{.raises: [ConfigurationError, Defect].} =
if not fromURI(result, p): if not fromURI(result, p):
raise newException(ConfigurationError, "Invalid ENR") raise newException(ValueError, "Invalid ENR")
func completeCmdArg*(T: type enr.Record, val: string): seq[string] = func completeCmdArg*(T: type enr.Record, val: string): seq[string] =
return @[] return @[]