From 73b3f40e8de22be8f2a244451156e3388a4816fb Mon Sep 17 00:00:00 2001
From: Etan Kissling <etan@status.im>
Date: Wed, 31 May 2023 21:07:06 +0200
Subject: [PATCH] use correct exception in `parseCmdArg(enr.Record)` (#5009)

* use correct exception in `parseCmdArg(enr.Record)`

`parseCmdArg` is expected to raise `ValueError` but for `enr.Record` we
currently raise `ConfigurationError`. Change to `ValueError` instead.

* lint
---
 beacon_chain/conf.nim | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/beacon_chain/conf.nim b/beacon_chain/conf.nim
index b0d229aba..4349c4588 100644
--- a/beacon_chain/conf.nim
+++ b/beacon_chain/conf.nim
@@ -1147,10 +1147,9 @@ func parseCmdArg*(T: type WalletName, input: string): T
 func completeCmdArg*(T: type WalletName, input: string): seq[string] =
   return @[]
 
-proc parseCmdArg*(T: type enr.Record, p: string): T
-    {.raises: [ConfigurationError, Defect].} =
+proc parseCmdArg*(T: type enr.Record, p: string): T {.raises: [ValueError].} =
   if not fromURI(result, p):
-    raise newException(ConfigurationError, "Invalid ENR")
+    raise newException(ValueError, "Invalid ENR")
 
 func completeCmdArg*(T: type enr.Record, val: string): seq[string] =
   return @[]