status-im
/
nimbus-eth2
mirror of https://github.com/status-im/nimbus-eth2.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

avoid pointlessly full blocks while handle blobsidecar REST requests (#5668)

This commit is contained in:
tersec 2023-12-14 17:02:36 +00:00 committed by GitHub
parent 44db870f59
commit 13c9f3b1e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
beacon_chain/rpc/rest_beacon_api.nim
View File

@ -1394,11 +1394,10 @@ proc installBeaconApiHandlers*(router: var RestRouter, node: BeaconNode) =
router.api(MethodGet, "/eth/v1/beacon/blob_sidecars/{block_id}") do ( router.api(MethodGet, "/eth/v1/beacon/blob_sidecars/{block_id}") do (
block_id: BlockIdent, indices: seq[uint64]) -> RestApiResponse: block_id: BlockIdent, indices: seq[uint64]) -> RestApiResponse:
let let
bid = block_id.valueOr: blockIdent = block_id.valueOr:
return RestApiResponse.jsonError(Http400, InvalidBlockIdValueError, return RestApiResponse.jsonError(Http400, InvalidBlockIdValueError,
$error) $error)
bid = node.getBlockId(blockIdent).valueOr:
bdata = node.getForkedBlock(bid).valueOr:
return RestApiResponse.jsonError(Http404, BlockNotFoundError) return RestApiResponse.jsonError(Http404, BlockNotFoundError)
contentType = block: contentType = block:
@ -1423,7 +1422,7 @@ proc installBeaconApiHandlers*(router: var RestRouter, node: BeaconNode) =
var blobSidecar = new BlobSidecar var blobSidecar = new BlobSidecar
if node.dag.db.getBlobSidecar(bdata.root, blobIndex, blobSidecar[]): if node.dag.db.getBlobSidecar(bid.root, blobIndex, blobSidecar[]):
discard data[].add blobSidecar[] discard data[].add blobSidecar[]
return return