avoid pointlessly full blocks while handle blobsidecar REST requests (#5668)
This commit is contained in:
parent
44db870f59
commit
13c9f3b1e1
|
@ -1394,11 +1394,10 @@ proc installBeaconApiHandlers*(router: var RestRouter, node: BeaconNode) =
|
||||||
router.api(MethodGet, "/eth/v1/beacon/blob_sidecars/{block_id}") do (
|
router.api(MethodGet, "/eth/v1/beacon/blob_sidecars/{block_id}") do (
|
||||||
block_id: BlockIdent, indices: seq[uint64]) -> RestApiResponse:
|
block_id: BlockIdent, indices: seq[uint64]) -> RestApiResponse:
|
||||||
let
|
let
|
||||||
bid = block_id.valueOr:
|
blockIdent = block_id.valueOr:
|
||||||
return RestApiResponse.jsonError(Http400, InvalidBlockIdValueError,
|
return RestApiResponse.jsonError(Http400, InvalidBlockIdValueError,
|
||||||
$error)
|
$error)
|
||||||
|
bid = node.getBlockId(blockIdent).valueOr:
|
||||||
bdata = node.getForkedBlock(bid).valueOr:
|
|
||||||
return RestApiResponse.jsonError(Http404, BlockNotFoundError)
|
return RestApiResponse.jsonError(Http404, BlockNotFoundError)
|
||||||
|
|
||||||
contentType = block:
|
contentType = block:
|
||||||
|
@ -1423,7 +1422,7 @@ proc installBeaconApiHandlers*(router: var RestRouter, node: BeaconNode) =
|
||||||
|
|
||||||
var blobSidecar = new BlobSidecar
|
var blobSidecar = new BlobSidecar
|
||||||
|
|
||||||
if node.dag.db.getBlobSidecar(bdata.root, blobIndex, blobSidecar[]):
|
if node.dag.db.getBlobSidecar(bid.root, blobIndex, blobSidecar[]):
|
||||||
discard data[].add blobSidecar[]
|
discard data[].add blobSidecar[]
|
||||||
|
|
||||||
return
|
return
|
||||||
|
|
Loading…
Reference in New Issue