From 13c9f3b1e13787fd73322731827e909eba3a9ce9 Mon Sep 17 00:00:00 2001 From: tersec Date: Thu, 14 Dec 2023 17:02:36 +0000 Subject: [PATCH] avoid pointlessly full blocks while handle blobsidecar REST requests (#5668) --- beacon_chain/rpc/rest_beacon_api.nim | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/beacon_chain/rpc/rest_beacon_api.nim b/beacon_chain/rpc/rest_beacon_api.nim index 29e606548..0070b987e 100644 --- a/beacon_chain/rpc/rest_beacon_api.nim +++ b/beacon_chain/rpc/rest_beacon_api.nim @@ -1394,11 +1394,10 @@ proc installBeaconApiHandlers*(router: var RestRouter, node: BeaconNode) = router.api(MethodGet, "/eth/v1/beacon/blob_sidecars/{block_id}") do ( block_id: BlockIdent, indices: seq[uint64]) -> RestApiResponse: let - bid = block_id.valueOr: + blockIdent = block_id.valueOr: return RestApiResponse.jsonError(Http400, InvalidBlockIdValueError, $error) - - bdata = node.getForkedBlock(bid).valueOr: + bid = node.getBlockId(blockIdent).valueOr: return RestApiResponse.jsonError(Http404, BlockNotFoundError) contentType = block: @@ -1423,7 +1422,7 @@ proc installBeaconApiHandlers*(router: var RestRouter, node: BeaconNode) = var blobSidecar = new BlobSidecar - if node.dag.db.getBlobSidecar(bdata.root, blobIndex, blobSidecar[]): + if node.dag.db.getBlobSidecar(bid.root, blobIndex, blobSidecar[]): discard data[].add blobSidecar[] return